Bug 1014978
| Summary: | fence-agents should have a sane a default for the reboot operation | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Jaroslav Kortus <jkortus> |
| Component: | pacemaker | Assignee: | Andrew Beekhof <abeekhof> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Cluster QE <mspqa-list> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.5 | CC: | cluster-maint, dvossel, fdinitto, mgrac, mjuricek, rbalakri, tlavigne |
| Target Milestone: | rc | Keywords: | Reopened |
| Target Release: | --- | Flags: | mgrac:
needinfo+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-25 15:13:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jaroslav Kortus
2013-10-03 09:05:17 UTC
This was fixed in 1.1.10-10 Dammit, wrong bug I disagree here. Allowing each agent to have its own default results inconsistent and non-obvious behaviour (as well as increasing the number of places to check for the value being used). The two agents should be doing something sane for 'reboot' instead. There are a number of agents that fake "reboot" by sending "off" + "on", do they not report success as long as "off" succeeds? This wouldn't seem much different. We'd also not be able to push such a change upstream as changing the Pacemaker defaults would cause compatibility issues with other tools and agents. Marek, fence_brocade has been rewritted since this bug was filed and fence_scsi has to be ported/fixed for rhel7. Can we address those issues without possibly introducing regressions vs current deployed setups in RHEL6? Otherwise we will need to document it for 6 and I´d like to see it fixed properly in 7 with a consistent reboot action across all agents. @Fabio, Those bugs should be fixed now. But we do not want to have action 'reboot' everywhere (and we never had) because fabric fence agents (e.g. switches, scsi, ... + kdump which is kind of special one as it does not have 'on') can not have reboot action. -- possible solutions: 1) add this information to fence agents XML 2) make cluster aware that the orders of default actions is reboot/off - cluster already has <actions> in XML, so this should not be a problem. I prefer, first version because this is not cluster specific. There is another option which I did not mention and is available/ready and supported. When action is not specified then default action is used, what is reboot/off according to fence agent. Is this acceptable? probably not as we need sane default for "reboot" action (see the summary and the history of this bug). Pacemaker always calls it with reboot and expects the agent to handle that. (In reply to Jaroslav Kortus from comment #9) > probably not as we need sane default for "reboot" action (see the summary > and the history of this bug). Pacemaker always calls it with reboot and > expects the agent to handle that. If no reboot is advertised in the agent's metadata xml, we'll revert to 'off'. https://github.com/ClusterLabs/pacemaker/commit/8383a38a478ed6473ff2179596335ed4de583cfa I put a big warning message in there so we'd know the 'reboot' to 'off' substitution took place because some agent didn't support 'reboot'. This seems like the path of least resistance in that it allows these couple of agents to work properly with the current pacemaker defaults. If people want the warnings to go away, they can change the default off operation. -- Vossel |