Bug 1015749 - Review Request: php-twig-ctwig - Extension to improve performance of Twig
Summary: Review Request: php-twig-ctwig - Extension to improve performance of Twig
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2013-10-05 05:24 UTC by Remi Collet
Modified: 2013-11-10 07:13 UTC (History)
3 users (show)

Fixed In Version: php-twig-ctwig-1.14.1-3.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-10-31 03:02:07 UTC
Type: ---
shawn: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
fedora-review (7.00 KB, text/plain)
2013-10-21 15:49 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2013-10-05 05:24:47 UTC
Spec URL: https://raw.github.com/remicollet/remirepo/5bb55ad37c631eb60928eb1f4cef0d67be0cfa5c/php/php-twig-CTwig/php-twig-CTwig.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-twig-CTwig-1.14.0-1.remi.src.rpm
Twig is a PHP template engine.

This package provides the Twig C extension (CTwig) to improve performance
of the Twig template language, used by Twig PHP extension (php-twig-Twig).

Fedora Account System Username: remi

- this is an optional dep of php-twig-Twig
- yes I prefer to keep EL-5 compatibility stuff
- yes I prefer to keep SCL stuff (as allowed by Guildeines)

Comment 1 Remi Collet 2013-10-05 07:56:30 UTC
As this is (AFAIK) the first "pecl" extension from a non standard channel, which is not covered by the current PHP Guidelines: https://fedorahosted.org/fpc/ticket/354

Comment 2 Remi Collet 2013-10-16 03:22:13 UTC
Update to 1.14.1, despite there is no change in source, only version bump, as upstream use the same repo for PHP anc C extension...

Spec: https://raw.github.com/remicollet/remirepo/33cac3138d34bb61bea0f5a2f441ef0f9564220c/php/php-twig-CTwig/php-twig-CTwig.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-twig-CTwig-1.14.1-1.remi.src.rpm

Comment 3 Remi Collet 2013-10-18 06:05:37 UTC
https://fedoraproject.org/wiki/Packaging:PHP have been updated.

Comment 6 Shawn Iwinski 2013-10-21 15:49:36 UTC
Created attachment 814685 [details]

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1015749
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api, C/C++
Disabled plugins: Java, Python, SugarActivity, Perl, R, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

Comment 7 Shawn Iwinski 2013-10-21 15:50:25 UTC
No blockers.

===== APPROVED =====

Comment 8 Remi Collet 2013-10-21 16:06:52 UTC
Big thanks for the review !

New Package SCM Request
Package Name: php-twig-ctwig
Short Description: Extension to improve performance of Twig
Owners: remi
Branches: f19 f20 el6

Comment 9 Gwyn Ciesla 2013-10-21 16:16:07 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2013-10-21 16:53:40 UTC
php-twig-ctwig-1.14.1-3.fc20 has been submitted as an update for Fedora 20.

Comment 11 Fedora Update System 2013-10-21 16:53:50 UTC
php-twig-ctwig-1.14.1-3.el6 has been submitted as an update for Fedora EPEL 6.

Comment 12 Fedora Update System 2013-10-21 16:53:59 UTC
php-twig-ctwig-1.14.1-3.fc19 has been submitted as an update for Fedora 19.

Comment 13 Fedora Update System 2013-10-22 05:03:42 UTC
php-twig-ctwig-1.14.1-3.fc19 has been pushed to the Fedora 19 testing repository.

Comment 14 Fedora Update System 2013-10-31 03:02:07 UTC
php-twig-ctwig-1.14.1-3.fc19 has been pushed to the Fedora 19 stable repository.

Comment 15 Fedora Update System 2013-11-06 18:26:16 UTC
php-twig-ctwig-1.14.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 16 Fedora Update System 2013-11-10 07:13:52 UTC
php-twig-ctwig-1.14.1-3.fc20 has been pushed to the Fedora 20 stable repository.

Note You need to log in before you can comment on or make changes to this bug.