RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1016064 - libndp: NDP option decoder issues
Summary: libndp: NDP option decoder issues
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libndp
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Jiri Pirko
QA Contact: Hangbin Liu
URL:
Whiteboard:
Depends On:
Blocks: 1016060
TreeView+ depends on / blocked
 
Reported: 2013-10-07 12:31 UTC by Florian Weimer
Modified: 2015-05-05 01:24 UTC (History)
4 users (show)

Fixed In Version: libndp-1.2-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 09:41:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2013-10-07 12:31:11 UTC
In ndp_msg_check_opts() in libndp/libndp.c, this code is used to parse the option header:

		uint8_t cur_opt_raw_type = ptr[0];
		uint8_t cur_opt_len = ptr[1] << 3; /* convert to bytes */

The type of cur_opt_len is incorrect, it should be unsigned, so that large values are not clipped.  With the current code, libndp parsing gets out of sync with the payload and subsequent options are not recognized.

In addition, RFC 2461 requires that packets with zero-length options are silently discarded.  The code merely stops options processing at the first zero-length option.

Comment 2 Florian Weimer 2013-10-07 12:33:58 UTC
ndp_msg_next_opt_offset() has the same problem.

Comment 8 Ludek Smid 2014-06-13 09:41:42 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.