Bug 1016081 - qpid java client example use AMQConnection instead of proper JMS Connection Factory
Summary: qpid java client example use AMQConnection instead of proper JMS Connection F...
Keywords:
Status: NEW
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: qpid-java
Version: 3.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: messaging-bugs
QA Contact: Messaging QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-07 13:05 UTC by Zdenek Kraus
Modified: 2020-11-04 22:31 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Zdenek Kraus 2013-10-07 13:05:23 UTC
Description of problem:
In our example client qpid-java-example, there is AMQConnection used, instead of proper JMS Connection Factory.

Version-Release number of selected component (if applicable):
qpid-java-example-0.23-1.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. rpm -ql "qpid-java-example"
/usr/share/doc/qpid-java-0.23/examples
/usr/share/doc/qpid-java-0.23/examples/example.log4j
/usr/share/doc/qpid-java-0.23/examples/org
/usr/share/doc/qpid-java-0.23/examples/org/apache
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/Drain.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/Hello.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/ListReceiver.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/ListSender.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/MapReceiver.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/MapSender.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/OptionParser.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/Spout.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/hello.properties
/usr/share/doc/qpid-java-0.23/examples/run_example.sh

2. grep 'AMQConnection' /usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/*.java
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/ListReceiver.java:import org.apache.qpid.client.AMQConnection;
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/ListReceiver.java:            new AMQConnection("amqp://guest:guest@test/?brokerlist='tcp://localhost:5672'");
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/ListSender.java:import org.apache.qpid.client.AMQConnection;
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/ListSender.java:            new AMQConnection("amqp://guest:guest@test/?brokerlist='tcp://localhost:5672'");
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/MapReceiver.java:import org.apache.qpid.client.AMQConnection;
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/MapReceiver.java:            new AMQConnection("amqp://guest:guest@test/?brokerlist='tcp://localhost:5672'");
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/MapSender.java:import org.apache.qpid.client.AMQConnection;
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/MapSender.java:            new AMQConnection("amqp://guest:guest@test/?brokerlist='tcp://localhost:5672'");
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/OptionParser.java:import org.apache.qpid.client.AMQConnection;
/usr/share/doc/qpid-java-0.23/examples/org/apache/qpid/example/OptionParser.java:        Connection con = new AMQConnection(buf.toString());



Actual results:
AMQConnection is used

Expected results:
Use proper JMS Connection Factory

Additional info:
Also in Doc: Messaging programming reference in Example 20.1. Sending a Java JMS MapMessage the client imports the AMQConnection, but the actual code is snipped. But the presence of such include is quite disturbing.


Note You need to log in before you can comment on or make changes to this bug.