RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1016465 - blockdev-setbsz succeeds, but does not affect blockdev-getbsz
Summary: blockdev-setbsz succeeds, but does not affect blockdev-getbsz
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libguestfs
Version: 7.0
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 624334
Blocks: 624335
TreeView+ depends on / blocked
 
Reported: 2013-10-08 08:39 UTC by Richard W.M. Jones
Modified: 2014-06-18 02:01 UTC (History)
6 users (show)

Fixed In Version: libguestfs-1.22.6-12.el7
Doc Type: Bug Fix
Doc Text:
Clone Of: 624334
Environment:
Last Closed: 2014-06-13 09:29:43 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Richard W.M. Jones 2013-10-08 08:39:01 UTC
+++ This bug was initially created as a clone of Bug #624334 +++

Version-Release number of selected component (if applicable):
1.5.2

How reproducible:
Always

Steps to Reproduce:
$ guestfish -a test.img
...
><fs> blockdev-getbsz /dev/sda
4096
><fs> blockdev-setbsz /dev/sda 2048
><fs> blockdev-getbsz /dev/sda
4096

Expected results:
blockdev-getbsz should return the latest block size we just set, or the blockdev-setbsz should return an error if the block size is not supported.

--- Additional comment from Richard W.M. Jones on 2013-09-20 04:53:12 EDT ---

https://bugzilla.redhat.com/show_bug.cgi?id=1002825 sheds more
light on this issue.

---

We should deprecate these calls and document
that they never worked.

Comment 2 Richard W.M. Jones 2013-10-16 12:31:37 UTC
commit 4fc44a0157a1bcd4c618e0eb8afd7c553ed0f31d
Author: Richard W.M. Jones <rjones>
Date:   Tue Oct 8 10:00:33 2013 +0100

    blockdev: Deprecate blockdev_setbsz and make it do nothing (RHBZ#624334).
    
    This call never did anything.  Don't use it.  Also I have submitted a
    patch upstream to remove the corresponding option from blockdev.
    
    See RHBZ#1002825 for an explanation of why this call was always
    useless.
    
    Thanks: Masayoshi Mizuma

Comment 4 Richard W.M. Jones 2013-10-16 18:56:39 UTC
libguestfs-1.22.6-12.el7
http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6429251

Comment 5 Can Zhang 2013-11-11 03:12:35 UTC
The man page of `guestfish` has documented `blockdev-setbsz` as "Do not use it", so I think it could be considered as "verified". Also, further works like fully removal of the API should be applied.

Comment 6 Richard W.M. Jones 2013-11-11 08:22:06 UTC
(In reply to Can Zhang from comment #5)
> The man page of `guestfish` has documented `blockdev-setbsz` as "Do not use
> it", so I think it could be considered as "verified". Also, further works
> like fully removal of the API should be applied.

APIs cannot be removed, because that would cause an ABI break
which we never do in libguestfs.

Comment 7 Ludek Smid 2014-06-13 09:29:43 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.