Hide Forgot
+++ This bug was initially created as a clone of Bug #624334 +++ Version-Release number of selected component (if applicable): 1.5.2 How reproducible: Always Steps to Reproduce: $ guestfish -a test.img ... ><fs> blockdev-getbsz /dev/sda 4096 ><fs> blockdev-setbsz /dev/sda 2048 ><fs> blockdev-getbsz /dev/sda 4096 Expected results: blockdev-getbsz should return the latest block size we just set, or the blockdev-setbsz should return an error if the block size is not supported. --- Additional comment from Richard W.M. Jones on 2013-09-20 04:53:12 EDT --- https://bugzilla.redhat.com/show_bug.cgi?id=1002825 sheds more light on this issue. --- We should deprecate these calls and document that they never worked.
commit 4fc44a0157a1bcd4c618e0eb8afd7c553ed0f31d Author: Richard W.M. Jones <rjones> Date: Tue Oct 8 10:00:33 2013 +0100 blockdev: Deprecate blockdev_setbsz and make it do nothing (RHBZ#624334). This call never did anything. Don't use it. Also I have submitted a patch upstream to remove the corresponding option from blockdev. See RHBZ#1002825 for an explanation of why this call was always useless. Thanks: Masayoshi Mizuma
libguestfs-1.22.6-12.el7 http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6429251
The man page of `guestfish` has documented `blockdev-setbsz` as "Do not use it", so I think it could be considered as "verified". Also, further works like fully removal of the API should be applied.
(In reply to Can Zhang from comment #5) > The man page of `guestfish` has documented `blockdev-setbsz` as "Do not use > it", so I think it could be considered as "verified". Also, further works > like fully removal of the API should be applied. APIs cannot be removed, because that would cause an ABI break which we never do in libguestfs.
This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request.