Bug 1016467 - External processes leak file descriptors
External processes leak file descriptors
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: python-blivet (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: David Lehman
Fedora Extras Quality Assurance
: Patch
Depends On:
Blocks: 1020013
  Show dependency treegraph
 
Reported: 2013-10-08 04:41 EDT by Jan Synacek
Modified: 2013-10-23 15:48 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1020013 (view as bug list)
Environment:
Last Closed: 2013-10-23 15:48:19 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
[Patch] upstream fix against the current master (25be7b9) (965 bytes, patch)
2013-10-08 04:43 EDT, Jan Synacek
no flags Details | Diff

  None (edit)
Description Jan Synacek 2013-10-08 04:41:11 EDT
Description of problem:
When working with lvm from blivet, I keep seeing messages like this in the log:

"
  INFO:program: Running... lvm pvs --unit=k --nosuffix --nameprefixes --rows --unquoted --noheadings -opv_uuid,pe_start,vg_name,vg_uuid,vg_size,vg_free,vg_extent_size,vg_extent_count,vg_free_count,pv_count --config global {locking_type=4}  /dev/vda4
  INFO:program: File descriptor 8 (/dev/mapper/control) leaked on lvm invocation. Parent PID 19615: python
"

Those may not be a problem, but they are a real problem if blivet tries to parse the output of an external program and instead of the real output, it gets something like "File descriptor 8 (/dev/mapper/control) leaked on lvm invocation. Parent PID 19976: python".


Version-Release number of selected component (if applicable):
python-blivet-0.22-1.fc21.noarch


How reproducible:
Always


Steps to Reproduce:
1. run blivet so it executes thinlvpoolname() in devicelibs/lvm.py
2. observe the output returned by the function


Actual results:
Output contains "File descriptor 8 (/dev/mapper/control) leaked on lvm invocation..." message and not the real output.


Expected results:
Output contains the name of the thin pool name as expected.


Additional info:
Comment 1 Jan Synacek 2013-10-08 04:43:03 EDT
Created attachment 809179 [details]
[Patch] upstream fix against the current master (25be7b9)
Comment 2 Jan Safranek 2013-10-08 04:49:32 EDT
Note that leaked file descriptors produce also several AVCs, like mdadm accessing /dev/mapper/control.
Comment 3 David Lehman 2013-10-23 15:48:19 EDT
Fixed by upstream commit dc64a4d3c74fd90f61 (master) in python-blivet-0.24-1 (f21/rawhide) and python-blivet-0.23.2-1 (f20).

Note You need to log in before you can comment on or make changes to this bug.