Bug 1016592 - Review Request: glassfish-enterprise-concurrent - Concurrency Utilities for Java EE
Summary: Review Request: glassfish-enterprise-concurrent - Concurrency Utilities for J...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: gil cattaneo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1016541
Blocks: 1016622
TreeView+ depends on / blocked
 
Reported: 2013-10-08 11:30 UTC by Marek Goldmann
Modified: 2013-10-09 13:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-10-09 13:50:01 UTC
puntogil: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
review notes (9.51 KB, text/plain)
2013-10-08 17:08 UTC, gil cattaneo
no flags Details

Description Marek Goldmann 2013-10-08 11:30:13 UTC
Spec URL: http://goldmann.fedorapeople.org/package_review/glassfish-enterprise-concurrent/1/glassfish-enterprise-concurrent.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/glassfish-enterprise-concurrent/1/glassfish-enterprise-concurrent-1.0-1.fc19.src.rpm
Fedora Account System Username: goldmann

Description:

Reference Implementation for JSR 236 - Concurrency Utilities for Java EE

Comment 1 Marek Goldmann 2013-10-08 14:32:40 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=6036558

Comment 2 gil cattaneo 2013-10-08 16:12:48 UTC
i would like to take this review

Comment 3 gil cattaneo 2013-10-08 17:08:21 UTC
Created attachment 809430 [details]
review notes

NOTE: manual review, caused:
Error: No package found for glassfish-enterprise-concurrent-api

NON blocking issues

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.

please, contact upstream to include a license copy
please, part of the license is available here,
can you handle this one with doc macro?

glassfish-enterprise-concurrent-1.0/src/main/java/doc-files/speclicense.html

approved

Comment 4 Marek Goldmann 2013-10-09 07:42:50 UTC
Thanks!

New Package SCM Request
=======================
Package Name: glassfish-enterprise-concurrent
Short Description: Concurrency Utilities for Java EE
Owners: goldmann
Branches: f20

Comment 5 Gwyn Ciesla 2013-10-09 12:08:18 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.