Bug 1016697 - Review Request: protostream - Infinispan ProtoStream
Summary: Review Request: protostream - Infinispan ProtoStream
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: gil cattaneo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 1016622
TreeView+ depends on / blocked
 
Reported: 2013-10-08 14:32 UTC by Marek Goldmann
Modified: 2013-10-09 13:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-10-09 13:46:52 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
puntogil: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
review notes (9.02 KB, text/plain)
2013-10-09 09:11 UTC, gil cattaneo
no flags Details

Description Marek Goldmann 2013-10-08 14:32:00 UTC
Spec URL: http://goldmann.fedorapeople.org/package_review/protostream/1/protostream.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/protostream/1/protostream-1.0.0-0.2.Alpha7.fc19.src.rpm
Fedora Account System Username: goldmann

Description:

The Infinispan ProtoStream project

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6036573

Comment 1 gil cattaneo 2013-10-09 08:49:26 UTC
i would like to take this review

Comment 2 gil cattaneo 2013-10-09 09:11:46 UTC
Created attachment 809798 [details]
review notes

Problems:

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 45 files have unknown license.

this file sample-domain-definition/src/main/resources/google/protobuf/descriptor.proto should be under BSD license, please update License field


[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.


please, contact upstream to include a license copy

Comment 3 Marek Goldmann 2013-10-09 10:01:20 UTC
Thanks!

New Package SCM Request
=======================
Package Name: protostream
Short Description: Infinispan ProtoStream
Owners: goldmann
Branches: f20

Comment 4 Gwyn Ciesla 2013-10-09 12:10:18 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.