Bug 1017701 - javapackages-tools: Incorrect versioned requires
Summary: javapackages-tools: Incorrect versioned requires
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: javapackages-tools
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-10 11:07 UTC by Mikolaj Izdebski
Modified: 2013-11-07 07:11 UTC (History)
4 users (show)

Fixed In Version: 3.4.1-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-07 07:11:17 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Mikolaj Izdebski 2013-10-10 11:07:42 UTC 
Description of problem:
In some cases generated requires are versioned when they should be versionless.

Version-Release number of selected component (if applicable):
3.3.1-1

Steps to Reproduce:
Run autorequires generator for package with the following two fragments:

$ cat api.xml 
<?xml version="1.0" encoding="US-ASCII"?>
<!-- This depmap file was generated by XMvn -->
<dependencyMap>
  <dependency>
    <maven>
      <namespace>maven31</namespace>
      <groupId>org.eclipse.aether</groupId>
      <artifactId>aether-api</artifactId>
      <version>0.9.0.M3</version>
    </maven>
    <jpp>
      <namespace>maven31</namespace>
      <groupId>JPP/maven31-aether</groupId>
      <artifactId>aether-api</artifactId>
    </jpp>
  </dependency>
</dependencyMap>

$ cat spi.xml 
<?xml version="1.0" encoding="US-ASCII"?>
<!-- This depmap file was generated by XMvn -->
<dependencyMap>
  <dependency>
    <maven>
      <namespace>maven31</namespace>
      <groupId>org.eclipse.aether</groupId>
      <artifactId>aether-spi</artifactId>
      <version>0.9.0.M3</version>
    </maven>
    <jpp>
      <namespace>maven31</namespace>
      <groupId>JPP/maven31-aether</groupId>
      <artifactId>aether-spi</artifactId>
    </jpp>
  </dependency>
  <autoRequires>
    <groupId>org.eclipse.aether</groupId>
    <artifactId>aether-api</artifactId>
  </autoRequires>
</dependencyMap>

Actual results:
Generated Requires is:
mvn(org.eclipse.aether:aether-api) = 0.9.0.M3

Expected results:
Generated Requires should be:
mvn(org.eclipse.aether:aether-api)
Comment 1 Stanislav Ochotnicky 2013-10-11 10:29:57 UTC 
Fix upstream in b03c361c937, test case in 782d6394 (fixed in 78f4748b)
Comment 2 Mikolaj Izdebski 2013-10-14 18:58:28 UTC 
Versioned requires are still not working as expected.

Version-Release number of selected component (if applicable):
3.4.0-2

New reproducer:

require.xml:
<dependencyMap>
  <dependency>
    <maven>
      <namespace>maven31</namespace>
      <groupId>org.eclipse.aether</groupId>
      <artifactId>aether-spi</artifactId>
      <version>0.9.0.M3</version>
    </maven>
    <jpp>
      <namespace>maven31</namespace>
      <groupId>JPP/maven31-aether</groupId>
      <artifactId>aether-spi</artifactId>
    </jpp>
  </dependency>
  <autoRequires>
    <namespace>maven31</namespace>
    <groupId>org.eclipse.aether</groupId>
    <artifactId>aether-api</artifactId>
  </autoRequires>
</dependencyMap>

fragment.xml:
<dependencyMap>
  <dependency>
    <maven>
      <namespace>maven31</namespace>
      <groupId>org.eclipse.aether</groupId>
      <artifactId>aether-api</artifactId>
      <version>0.9.0.M3</version>
    </maven>
    <jpp>
      <namespace>maven31</namespace>
      <groupId>JPP/maven31-aether</groupId>
      <artifactId>aether-api</artifactId>
    </jpp>
  </dependency>
</dependencyMap>

Expected require generated:
maven31-mvn(org.eclipse.aether:aether-api) = 0.9.0.M3

Actual require generated:
maven31-mvn(org.eclipse.aether:aether-api)
Comment 3 Mikolaj Izdebski 2013-10-15 06:52:20 UTC 
Reproducer added as a unit test case in 05c839bc
Comment 4 Stanislav Ochotnicky 2013-10-15 11:04:26 UTC 
Fixed upstream in 0fd12961
Comment 5 Mikolaj Izdebski 2013-11-07 07:08:32 UTC 
Fixed in javapackages-tools-3.4.1-1
Comment 6 Mikolaj Izdebski 2013-11-07 07:11:17 UTC 
I believe that this bug is fixed in javapackages-tools-3.4.1-1,
which is available in Fedora Rawhide, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=476325
Note You need to log in before you can comment on or make changes to this bug.