Description of problem: Create apps on devenv-stage_491, upgrade the server and run datastore migration. Try to upgrade the gears via oo-admin-upgrade, nodejs app will fail and found following error in the upgrade_error log: "upgrade_script_nodejs": { "context": { "cartridge": "nodejs", "rc": 1, "stderr": "mkdir: cannot create directory `/node_modules': Permission denied\nmv: target `/node_modules' is not a directory\nln: creating symbolic link `/var/lib/openshift/52566e675534c5a5db000239/nodejs//node_modules/node_modules': File exists\nln: creating symbolic link `/var/lib/openshift/52566e675534c5a5db000239//.node_modules/node_modules': File exists\n", "stdout": "" }, "errors": [ "Upgrade script for nodejs returned a non-zero exit code (1)" ], "status": "incomplete" } Version-Release number of selected component (if applicable): devenv-stage_491 to devenv_3881 How reproducible: always Steps to Reproduce: 1.Create test data on devenv-stage_491 2.Upgrade the server and run compatible migration for datastore 3.Upgrade the gears via oo-admin-upgrade # oo-admin-upgrade upgrade-node --version 3.0.35 --ignore-cartridge-version Actual results: Nodejs app will fail during the gear upgrade. Expected results: App should be upgraded successfully. Additional info:
https://github.com/openshift/origin-server/pull/3844
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/6fdd4bf5c0ad2e87e5f4626d508299917a2d85bd Bug 1017721: Fix nodejs upgrade mv operation Don't attempt to create and populate node_modules if it's already a symlink to the source.
Issue fixed on devenv_3901, move bug to verified.