Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-descendants_tracker.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-descendants_tracker-0.0.3-1.fc20.src.rpm Description: Module that adds descendant tracking to a class. Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6048961
Taking. I would appreciate it if you would review my review request (bug 1025095 ) - this is needed to resolve bug 1024931 from people using alexandria.
Except for files list, I have nothing to ask you to modify. Then: * Please check if the following files really need being packaged in binary rpm: - Gemfile - Guardfile - Rakefile * spec/ directory and anything below it is usually meant to be used only on test suite, and current Ruby guideline recommends not to package it: ref: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites notice "Do not ship tests" * I recommend to move README.md to main package. ? I don't object to including TODO file, however please note that currently this file is empty.
Thanks - I've made all your suggested changes. Here's the newest version. * Fri Nov 01 2013 Ken Dreyer <ktdreyer> - 0.0.3-2 - Updates for Fedora package review request (RHBZ #1018004) - Remove developer-only files during %%prep - Exclude test suite from binary RPMs - Move README to main package Specific changes (in git): http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-descendants_tracker.git/commit/?id=b1a808889bd1e28299e0e4f04f820c9fdb758c9d Spec: http://ktdreyer.fedorapeople.org/reviews/rubygem-descendants_tracker.spec SRPM: http://ktdreyer.fedorapeople.org/reviews/rubygem-descendants_tracker-0.0.3-2.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6123339
* Well, one minor point is that %exclude %doc can simply be %exclude. * Also, you can simply add %exclude or using rm on %install for Gemfile and etc (instead of modifying gemspec), as you also use %exclude for other files However there are no blockers, approving. ----------------------------------------------------- This package (rubygem-descendants_tracker) is APPROVED by mtasaka -----------------------------------------------------
(In reply to Mamoru TASAKA from comment #4) > * Well, one minor point is that %exclude %doc can simply be %exclude. Thanks, this was a typo. I'll adjust it before importing. > * Also, you can simply add %exclude or using rm on %install for Gemfile > and etc (instead of modifying gemspec), as you also use %exclude for > other files You're right, maybe I ought to pick one or the other. I'm not keen on having a gemspec that lists a lot of extra files that the RPM doesn't actually ship, so I prefer to eliminate the files during %prep. On the other hand, we need the test suite to be available during %check, so we have to keep that in the gemspsec that and then %exclude it later. So both options seem to have disadvantages.
Thank you very much for the review! New Package SCM Request ======================= Package Name: rubygem-descendants_tracker Short Description: Module that adds descendant tracking to a class Owners: ktdreyer Branches: f19 f20
Git done (by process-git-requests).
rubygem-descendants_tracker-0.0.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-descendants_tracker-0.0.3-2.fc20
rubygem-descendants_tracker-0.0.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-descendants_tracker-0.0.3-2.fc19
rubygem-descendants_tracker-0.0.3-2.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-descendants_tracker-0.0.3-2.fc20 has been pushed to the Fedora 20 stable repository.
rubygem-descendants_tracker-0.0.3-2.fc19 has been pushed to the Fedora 19 stable repository.