Red Hat Bugzilla – Bug 1018179
Let jboss-as-7 plug-in discover Infinispan subsystem in Infinispan server also using community plug-in
Last modified: 2014-01-02 15:42:54 EST
I hope I've found what exactly cause our recent (JDG) problems with discovering Infinispan subsystem under Infinispan server.
Our plug-in renamed since JDG 6.1 GA from "JDG" to more community related "InfinispanServer".
However, looking into jboss-as-7 plug-in (we are based on this, of course) here:
boolean ourPluginTypeIsJdg = ourType.getPlugin().equals("JDG");
only "JDG" name is taking into account. So when plug-in is named "InfinispanServer" ourPluginTypeIsJdg is set to false, and output of a method shouldSkipEntryWrtIspn() is true and Infinispan subsystem is skipped.
Would it be possible to take "InfinispanServer" plug-in name into account as well?
Hopefully: boolean ourPluginTypeIsJdg = (ourType.getPlugin().equals("JDG") || (ourType.getPlugin().equals("InfinispanServer")); should be enough.
Or maybe some "more-complex" pattern for deciding about Infinispan/JDG plug-in names?
Thank you very much!
Is anyone looking into it?
If I didn't miss something, it was not fixed in target ER05 release.
This is fixed with commit : 7af64a34c1c03f to release branch and also cherrypicked to master as well.
@Tomas, the suggested patch seems fine. In future these types of changes should be able to be handled by new plugin callback functionality described here without needing explicit changes in the as7/eap plugin : https://docs.jboss.org/author/display/RHQ/Discovery+Callbacks
Moving this to MODIFIED for testing with next brew build.
Thank you Simeon!
I will play with it immediately once I put my hands on fresh ER06.
Moving to ON_QA as available for testing with new brew build.
Mass moving all of these from ER6 to target milestone ER07 since the ER6 build was bad and QE was halted for the same reason.