Created attachment 811342 [details] Patch Description of problem: The value of --plugin-option is set to be of type string when adding the option to the OptionParser. The values are then passed as string to the respective option receivers. This makes it impossible to pass i.e. bind_mount:dirs via --plugin-option, since bind_mount.py expects dirs to be an 2d-iterable (i.e. tuple of tuples), but it will get a string. One possibly clean fix would be to pass all values of --plugin-option though literal_eval. If literal_eval fails, then it is likely an actual string, and it is kept as such. Otherwise, the string is parsed to a python object. The only risk is that the user passes an argument which should be a string but also is valid python syntax. To avoid these issues, the user should quote the value, i.e. --plugin-option="myplugin:key='value'" Version-Release number of selected component (if applicable): mock-1.1.33-1.fc21.noarch How reproducible: Always Steps to Reproduce: 1. Try to pass --plugin-option="bind_mount:dirs=(('/foo','/bar')) to mock 2. The bind_mount plugin will fail parsing the dirs option
Applied for mock-1.1.34 release
mock-1.1.34-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mock-1.1.34-1.fc18
mock-1.1.34-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.34-1.el6
mock-1.1.34-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mock-1.1.34-1.fc20
mock-1.1.34-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mock-1.1.34-1.fc19
Package mock-1.1.34-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mock-1.1.34-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-20329/mock-1.1.34-1.fc20 then log in and leave karma (feedback).
mock-1.1.35-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mock-1.1.35-1.fc19
mock-1.1.35-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mock-1.1.35-1.fc18
mock-1.1.35-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.35-1.el6
mock-1.1.35-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mock-1.1.35-1.fc20
mock-1.1.35-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.36-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mock-1.1.36-1.fc19
mock-1.1.36-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mock-1.1.36-1.fc20
mock-1.1.36-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.36-1.el6
mock-1.1.36-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.37-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mock-1.1.37-1.fc19
mock-1.1.37-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mock-1.1.37-1.fc20
mock-1.1.37-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.37-1.el6
mock-1.1.37-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mock-1.1.37-2.fc20
mock-1.1.37-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mock-1.1.37-2.fc19
mock-1.1.37-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.37-2.el6
mock-1.1.38-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mock-1.1.38-1.fc19
mock-1.1.38-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.38-1.el6
mock-1.1.38-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mock-1.1.38-1.fc20
mock-1.1.38-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.38-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.38-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
Test with mock-1.2.17-1.el7.noarch. mock with argument --plugin-option="bind_mount:dirs=(('/foo','/bar')) still fails like $ mock --plugin-option="bind_mount:dirs=(('/public','/tmp/t1'))" --shell INFO: mock.py version 1.2.17 starting (python version = 2.7.5)... Start: init plugins ERROR: too many values to unpack Traceback (most recent call last): File "/usr/sbin/mock", line 849, in <module> main() File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace result = func(*args, **kw) File "/usr/sbin/mock", line 635, in main buildroot = Buildroot(config_opts, uidManager, state, plugins) File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/buildroot.py", line 68, in __init__ self.plugins.init_plugins(self) File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/plugin.py", line 56, in init_plugins module.init(self, self.plugin_conf["{0}_opts".format(plugin)], buildroot) File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/plugins/bind_mount.py", line 22, in init BindMount(plugins, conf, buildroot) File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/plugins/bind_mount.py", line 34, in __init__ for srcdir, destdir in self.bind_opts['dirs']: ValueError: too many values to unpack