Bug 1018390 - gtk3: Net/FallbackIconTheme regression/non-functional
Summary: gtk3: Net/FallbackIconTheme regression/non-functional
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gtk3
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F20Target-kde
TreeView+ depends on / blocked
 
Reported: 2013-10-11 20:34 UTC by Rex Dieter
Modified: 2013-11-10 06:43 UTC (History)
5 users (show)

Fixed In Version: gtk3-3.10.2-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-10 06:43:37 UTC


Attachments (Terms of Use)
screenshot demonstrating missing toolbar icons (25.22 KB, image/png)
2013-10-11 20:37 UTC, Rex Dieter
no flags Details


Links
System ID Priority Status Summary Last Updated
GNOME Bugzilla 708163 None None None Never

Description Rex Dieter 2013-10-11 20:34:39 UTC
gtk3 apps on kde are often without proper icons on f20, I *suspect* something changed or not working as expected with Net/FallbackIconTheme 

In particular, xsettings-kde, sets Net/FallbackIconTheme to gnome.

evince, for example, doesn't show any of it's usual symbolic toolbar icons when using kde's default oxygen-icons.

If I set icon theme to Fedora/gnome or modify oxygen/index.theme
Inherits=gnome,hicolor

then it works again.

Comment 1 Rex Dieter 2013-10-11 20:37:19 UTC
Created attachment 811388 [details]
screenshot demonstrating missing toolbar icons

Comment 2 Rex Dieter 2013-10-11 20:42:05 UTC
Oh, eep, googling finds:

http://osdir.com/ml/commits.gnome/2013-06/msg06019.html

"Deprecate and ignore gtk-fallback-icon-theme
The standard icon themes have built in fallbacks."

A little unfortunate, but I suppose we can patch oxygen with the workaround mentioned in comment #1

Unless, there's some other better suggestion?

Comment 3 Kevin Kofler 2013-10-11 20:50:20 UTC
Inheriting the GNOME theme in Oxygen makes no sense whatsoever. The same way the implied fallback for KDE apps is Oxygen, the implied fallback for GNOME/GTK+ apps needs to be the GNOME theme. KDE apps should not fall back to the GNOME theme, that just doesn't make sense.

In addition, it wouldn't fix the problem for people using themes inheriting neither Oxygen nor GNOME. It doesn't make sense to expect all of them to inherit the GNOME theme nor to provide the non-freedesktop.org symbolic icons.

Net/FallbackIconTheme is REQUIRED for GTK+ to work properly with any icon theme that does not inherit the GNOME theme. The freedesktop.org icon theme specifies nowhere that themes must inherit the GNOME theme nor that they have to provide the same nonstandard icons. The upstream patch breaks all the non-GNOME freedesktop.org-compliant icon themes for GTK+ apps and needs to be reverted.

Comment 4 Kevin Kofler 2013-10-11 20:52:25 UTC
Oh, and if you really want to get rid of the setting, why not just hardcode it to "gnome" instead of dropping the functionality completely? That's what everyone (even xsettings-kde) sets Net/FallbackIconTheme to anyway.

Comment 5 Rex Dieter 2013-10-11 20:55:27 UTC
I would tend to agree with that assessment, in particular, I don't think it unreasonable to ask that gtk3 apps to implicitly fallback to gnome-icon-theme somehow.

I don't care about the implementation details, whether that means re-implementing Net/FallbackIconTheme or some hard-coded fallback in gtk3, or some other even better idea.

Comment 6 Kamil Páral 2013-10-21 11:08:42 UTC
This might be related (already partially linked in comment 2):

https://mail.gnome.org/archives/gtk-devel-list/2013-July/msg00000.html

Comment 7 Rex Dieter 2013-10-21 11:58:59 UTC
That is a separate issue (and easier to identify and fix, applications that use that deprecated stock icons api fail to build)

Comment 8 Matthias Clasen 2013-10-21 12:21:41 UTC
Should be fixed in 3.10.2 with

https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-10&id=d25ee710715c60801b29289c4a0ee85fb337579c

Comment 9 Rex Dieter 2013-10-21 12:55:13 UTC
Thanks.

Comment 10 Rex Dieter 2013-10-21 15:31:05 UTC
Testing with gtk3-3.10.2-1.fc20.x86_64 , I'm still seeing what appears to be a fair number of missing icons in evince, per the screenshot posted in comment #1

Comment 11 Matthias Clasen 2013-10-21 16:28:53 UTC
We'll have to look into how those buttons are constructed - maybe they are not doing generic fallback for icon names.

Comment 12 Matthias Clasen 2013-10-21 16:54:18 UTC
Does oxygen not ship standard icons like go-up, go-down ?

Comment 13 Rex Dieter 2013-10-21 17:09:10 UTC
It does,

$ rpm -ql oxygen-icon-theme | grep -e 'go-[ud]'
/usr/share/icons/oxygen/128x128/actions/go-down.png
/usr/share/icons/oxygen/128x128/actions/go-up.png
/usr/share/icons/oxygen/16x16/actions/go-down-search.png
/usr/share/icons/oxygen/16x16/actions/go-down.png
/usr/share/icons/oxygen/16x16/actions/go-up-search.png
/usr/share/icons/oxygen/16x16/actions/go-up.png
/usr/share/icons/oxygen/22x22/actions/go-down-search.png
/usr/share/icons/oxygen/22x22/actions/go-down.png
/usr/share/icons/oxygen/22x22/actions/go-up-search.png
/usr/share/icons/oxygen/22x22/actions/go-up.png
/usr/share/icons/oxygen/32x32/actions/go-down-search.png
/usr/share/icons/oxygen/32x32/actions/go-down.png
/usr/share/icons/oxygen/32x32/actions/go-up-search.png
/usr/share/icons/oxygen/32x32/actions/go-up.png
/usr/share/icons/oxygen/48x48/actions/go-down-search.png
/usr/share/icons/oxygen/48x48/actions/go-down.png
/usr/share/icons/oxygen/48x48/actions/go-up-search.png
/usr/share/icons/oxygen/48x48/actions/go-up.png
/usr/share/icons/oxygen/64x64/actions/go-down.png
/usr/share/icons/oxygen/64x64/actions/go-up.png

Comment 14 Fedora Update System 2013-10-21 17:55:40 UTC
gtk3-3.10.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gtk3-3.10.2-2.fc20

Comment 15 Rex Dieter 2013-10-21 18:40:01 UTC
Thanks, confirmed good.

Comment 16 Fedora Update System 2013-10-22 18:54:09 UTC
Package gtk3-3.10.2-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gtk3-3.10.2-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-19701/gtk3-3.10.2-2.fc20
then log in and leave karma (feedback).

Comment 17 Fedora Update System 2013-11-10 06:43:37 UTC
gtk3-3.10.2-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.