Bug 1018489 - Review Request: griffon - A Grails-like Rich Application Platform
Review Request: griffon - A Grails-like Rich Application Platform
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2013-10-12 11:36 EDT by Alex Irmel Oviedo Solis
Modified: 2017-02-19 07:06 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-02-13 08:09:40 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Alex Irmel Oviedo Solis 2013-10-12 11:36:30 EDT
Spec URL: http://alexove.fedorapeople.org/rpmbuild/SPECS/griffon.spec
SRPM URL: http://alexove.fedorapeople.org/rpmbuild/SRPMS/griffon-1.4.0-1.fc19.src.rpm
Description: Griffon is an application framework for developing desktop applications in the JVM, with Groovy being the primary language of choice.
Fedora Account System Username: alexove
Comment 1 Alex Irmel Oviedo Solis 2013-10-12 11:40:29 EDT
This is my first package for fedora. I need a package sponsor, I propose to echevemaster as my sponsor please.
Comment 2 Alex Irmel Oviedo Solis 2013-10-12 11:41:20 EDT
This is my first package for fedora. I need a package sponsor, propose to echevemaste as my sponsor, please
Comment 3 Christopher Meng 2013-10-12 14:05:41 EDT
DO NOT CHANGE FIELDS REGARDLESS OF YOURS.
Comment 4 Johan Swensson 2013-10-21 16:26:52 EDT
* License tag is invalid.
* Documentation is not put in the correct place. Take a look at the %doc macro.
* Package contains prepackaged jar-files: http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software
* Use a correct Source URL http://fedoraproject.org/wiki/Packaging:SourceURL
* Upstream url seems invalid, it should probably be http://griffon.codehaus.org and not http://www.grails.org

I'm afraid this package is gonna need some work. These are just some starting points.

Rpmlint
-------
Checking: griffon-1.4.0-1.fc19.noarch.rpm
          griffon-1.4.0-1.fc19.src.rpm
griffon.noarch: E: devel-dependency java-devel
griffon.noarch: W: no-version-in-last-changelog
griffon.noarch: W: invalid-license Apache 2.0
griffon.noarch: W: no-documentation
griffon.noarch: E: zero-length /usr/share/griffon/samples/GroovyEdit/griffon-app/i18n/messages.properties
griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/lifecycle/Stop.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Shutdown.groovy
griffon.noarch: E: script-without-shebang /usr/share/griffon/samples/Greet/griffon-app/services/greet/MicroblogService.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Ready.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/i18n/messages.properties
griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/lifecycle/Ready.groovy
griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/griffonsh.bat
griffon.noarch: E: wrong-script-end-of-line-encoding /usr/share/griffon/bin/griffonsh.bat
griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/startGriffon
griffon.noarch: E: zero-length /usr/share/griffon/samples/FileViewer/griffon-app/lifecycle/Stop.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/lifecycle/Stop.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Startup.groovy
griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/griffon-debug.bat
griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Stop.groovy
griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/startGriffon.bat
griffon.noarch: E: wrong-script-end-of-line-encoding /usr/share/griffon/bin/startGriffon.bat
griffon.noarch: E: zero-length /usr/share/griffon/samples/FileViewer/griffon-app/i18n/messages.properties
griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/griffon.bat
griffon.noarch: E: wrong-script-end-of-line-encoding /usr/share/griffon/bin/griffon.bat
griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/lifecycle/Shutdown.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/lifecycle/Startup.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/i18n/messages.properties
griffon.noarch: E: script-without-shebang /usr/share/griffon/samples/Greet/test/unit/MicroblogServiceTests.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/lifecycle/Shutdown.groovy
griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/i18n/messages.properties
griffon.noarch: W: empty-%post
griffon.noarch: W: class-path-in-manifest /usr/share/griffon/lib/itext-2.0.8.jar
griffon.noarch: W: class-path-in-manifest /usr/share/griffon/lib/radeox-1.0-b2.jar
griffon.src: W: no-version-in-last-changelog
griffon.src: W: invalid-license Apache 2.0
griffon.src: W: invalid-url Source0: griffon-1.4.0-src.tgz
2 packages and 0 specfiles checked; 27 errors, 9 warnings.
Comment 5 Eduardo Echeverria 2014-01-21 22:33:08 EST
Lifting FE-NEEDSPONSOR, Alex has been sponsored.
Comment 6 Christopher Meng 2014-01-22 00:04:46 EST
You can use %{version} macro in the Source0 tag.
Comment 7 gil cattaneo 2015-12-12 04:53:34 EST
New home:    http://griffon-framework.org/
New release: 2.5.0 https://github.com/griffon/griffon/tags
Please, rework your spec file to use system libraries

Note You need to log in before you can comment on or make changes to this bug.