Bug 1018575 - pmatop exceptions need better catching
Summary: pmatop exceptions need better catching
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: pcp
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nathan Scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-13 14:16 UTC by Frank Ch. Eigler
Modified: 2015-08-22 16:34 UTC (History)
6 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2015-08-13 16:56:59 UTC


Attachments (Terms of Use)

Description Frank Ch. Eigler 2013-10-13 14:16:46 UTC
On a small gnome-terminal (measly 90x24), git pmatop (targeted
to a machine with lots of disks/cpus) finds it easy to trigger
curses errors, exiting the whole program.  Easily reproducible:
% python pmatop.py
press random keys to evoke the online-help ditty, but get:

Traceback (most recent call last):
  File "pmatop.py", line 771, in <module>
    status = curses.wrapper(main)   # pylint: disable-msg=C0103
  File "/usr/lib64/python2.7/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "pmatop.py", line 748, in main
    stdscr.addstr ("Invalid command %s\nType 'h' to see a list of valid commands" % (cmd))
  File "pmatop.py", line 144, in addstr
    self.so_stdscr.addstr (str)
_curses.error: addstr() returned ERR


In general, these python programs (pmatop and pmcollectl) need more
systematic exception catching; maybe a full-fledged curses error-reporting
screen?

Comment 1 Stan Cox 2014-05-27 15:05:25 UTC
sourceware.org/git/pcpfans.git scox/dev commit 77377f219088
Handle curses problems gracefully.

Whenever a curses problem is encountered the above gives the error message:
% pmatop
Error in the curses module.  Try running pmatop in a larger window.

Comment 2 Jaroslav Reznik 2015-03-03 16:56:03 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 3 Fedora Update System 2015-06-16 02:12:29 UTC
pcp-3.10.5-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/pcp-3.10.5-1.fc22

Comment 4 Fedora Update System 2015-06-16 02:13:42 UTC
pcp-3.10.5-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/pcp-3.10.5-1.fc21

Comment 5 Fedora Update System 2015-06-16 02:14:38 UTC
pcp-3.10.5-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/pcp-3.10.5-1.fc20

Comment 6 Fedora Update System 2015-06-16 02:16:38 UTC
pcp-3.10.5-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/pcp-3.10.5-1.el5

Comment 7 Fedora Update System 2015-06-18 18:34:41 UTC
Package pcp-3.10.5-1.el5:
* should fix your issue,
* was pushed to the Fedora EPEL 5 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing pcp-3.10.5-1.el5'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6718/pcp-3.10.5-1.el5
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2015-08-04 05:37:44 UTC
pcp-3.10.6-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/pcp-3.10.6-1.fc22

Comment 9 Fedora Update System 2015-08-04 05:38:29 UTC
pcp-3.10.6-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/pcp-3.10.6-1.fc21

Comment 10 Fedora Update System 2015-08-04 05:39:15 UTC
pcp-3.10.6-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/pcp-3.10.6-1.el5

Comment 11 Fedora Update System 2015-08-13 16:56:59 UTC
pcp-3.10.6-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2015-08-13 16:58:40 UTC
pcp-3.10.6-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-08-22 16:33:43 UTC
pcp-3.10.6-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.