Red Hat Bugzilla – Bug 1018973
Changes to the libvirt network type do not save
Last modified: 2014-07-02 10:05:29 EDT
Description of problem:
Changing network type and then saving the form will not work. For example, if I change the network to be NAT'ed and save the form, it will still show as bridged the next time I load the edit page.
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.
does it mean we incorrectly save the vm or just display it incorrectly?
Editing a VM, or creating a new one?
Finally looking into this, my dev setup was broken due to other small bugs (fixed now).
This occurs when editing a VM or creating a new one. It looks like the first network type gets chosen when saving and then you can't edit. On the installation I'm looking at the issue is not only aesthetic - the change actually doesn't get saved with libvirt.
Yeah, not being able to edit VM properties is quite common for Foreman CRs. Ideally we can fix the retrieval, but if we can't edit reliably then the dropdown could be locked (like Martin did the other day for VMware).
This occurs on a local libvirt connection, too. The installation consistently doesn't save the changes so I doubt it's just a connectivity problem over the wire.
I just reproduced on a new host entry, I never powered the host up. Digging into.
Okay, libvirtd should support editing (since virt-manager can apparently edit stuff), but fog library, which is used by Foreman, does not. We can do the upstream work to support it, but I don't believe we will manage to get the fog patch for MDP2.
For this reason I also recommend to implement "UI greying" for those compute resources who does not support editing. That is: all except ovirt right now.
Speaking about new VM libvirt, I am not able to reproduce. I can select and create all combinations of bridge and nat, it just save for me. Can you retest and before that restart libvirtd? Haven't you been editing networks previously via virsh or virt-manager there?
I have implemented greying upstream: http://projects.theforeman.org/issues/3338
(In reply to Lukas Zapletal from comment #12)
> I have implemented greying upstream:
There's already a redmine ticket associated with this BZ, close one as a dupe?
Oh sorry missed that. Closing #3286, thanks.
Just to make sure, Sam, I was unable to reproduce when I was creating NEW host. I checked with Todd and he confirmed me it was happening only for existing hosts. So once the upstream is closed we can close this one.
Fixed in f9a773198bb569d67b1fff0a90f4412276d33122.
Verified with sat6 beta snap6..(Satellite-6.0.3-RHEL-6-20140523.0).
I'm not sure the exact steps to verify this bz, but from the description of the bug it seems that on saving form, the selected 'network' type' was not retained.
So to reproduce this, I created a new host and I got two network types:
I selected the Virtual(NAT) and on saving form the selected network type i.e. Virtual(NAT) retained.
Later, when I edited the existing host, the form was grayed out and I couldn't change any thing. As per changes in comment12, it seems its working as expected.
@Lukas: Please confirm if I correctly verified this bz.
Created attachment 899391 [details]
greyout form on editing an existing host
Yes this is correct behavior right now, unfortunately any better solution is too much work.
As per comment 19 and 21.. moving this bz to verified.
That's the only way we can do with the current fog library. I can confirm.
Upstream bug http://projects.theforeman.org/issues/3286 is rejected, and this is verified. I am removing the url.
This was delivered with 6.0.3, which is the Satellite 6 Beta.