Spec URL: http://kupo.se/pub/review/pylcdsysinfo.spec SRPM URL: http://kupo.se/pub/review/pylcdsysinfo-0.0.1-5.20131014git98e1b80.fc19.src.rpm Description: LCD Sys Info is an USB LCD gadget which display system and environmental information or pictures from your computer. Fedora Account System Username: opuk
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=6066487
A template of mine: http://cicku.me/python-pygit2.spec 1. BuildRequires: python2-devel AND BuildRequires: python-setuptools 2. No %build? Kidding? %{__python2} setup.py build 3. Ask upstream to tag their project.
D'oh. Of course there is a %build. :) Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6072006 Spec URL: http://kupo.se/pub/review/pylcdsysinfo.spec SRPM URL: http://kupo.se/pub/review/pylcdsysinfo-0.0.1-6.20131014git98e1b80.fc19.src.rpm
It seems to me that the version is made up, because upstream does not provide one. Please use "0" then instead of "0.0.1" - "0" is afaik the lowest possible version. Also the release should be formed like 0.%{X}.%{alphatag}, because it is a pre-release (see the kismet example): https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
Spec URL: http://kupo.se/pub/review/pylcdsysinfo.spec SRPM URL: http://kupo.se/pub/review/pylcdsysinfo-0-0.7.20131014git.fc19.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6083347 %changelog * Mon Oct 21 2013 Johan Swensson <kupo> - 0-0.7.20131014git - Changed version string to comply with guidelines - Updated changelog entires to reflect the corrected version string
Hm, come of think of it I probably should have named this package python-pylcdsysinfo. I'll wait for feedback before doing anything.
Yes, the modern naming guidelines mandate the "python-" prefix for the %{parent}-%{child} relationship when it's a Python Module. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 There used to be an exception for projects with a "py" or "Py" prefix, but it has been removed, albeit incompletely, see: https://lists.fedoraproject.org/pipermail/packaging/2013-October/009674.html
What would be the preferred way to do this? Close this review and file a new one with the correct name or simply rename it and post the new SRPM and spec in this review?
Just change it here is OK. Avoid creating dups again ;)
The ticket title can be edited, too, so renaming during review is possible.
One of the most helpful things about the fedora-review tool is its "license check" feature: GPL (v3 or later) ----------------- /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/pylcdsysinfo-98e1b802b1cf8ce7a7482343d85b9449b4f8459e/pylcdsysinfo.py Same for USAGE.txt. That would be "License: GPLv3+" in the spec file, but the README.md at the bottom says "GPL v3", so asking for clarification would be justified. Upstream git mentions fixes for Python 3. Is it Python 2 only so far? Or does it work with Python 3 yet? If so, a python3-* subpackage could be built. I do not possess the hardware to test with, so for the optional run-time testing I've only verified that module imports.
I will check that with upstream. Upstream does support Python 3, however the required pyusb is not packaged for Python 3 yet. I have pinged the maintainer of that package recently asking to add support for it. I will file a bugzilla about it.
Upstream says license is GPLv3 only. Package is now renamed. Spec URL: http://kupo.se/pub/review/python-pylcdsysinfo.spec SRPM URL: http://kupo.se/pub/review/python-pylcdsysinfo-0-0.8.20131014git.fc19.src.rpm
(In reply to Johan Swensson from comment #12) > I will file a bugzilla about it. https://bugzilla.redhat.com/show_bug.cgi?id=1022851
That's a clean update (judging about it based on the diff). APPROVED
New Package SCM Request ======================= Package Name: python-pylcdsysinfo Short Description: Python interface to Coldtears Electronics LCD Sys Info device Owners: opuk Branches: f18 f19 f20 InitialCC:
Git done (by process-git-requests).
python-pylcdsysinfo-0-0.8.20131014git.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-pylcdsysinfo-0-0.8.20131014git.fc20
python-pylcdsysinfo-0-0.8.20131014git.fc20 has been pushed to the Fedora 20 testing repository.
python-pylcdsysinfo-0-0.8.20131014git.fc20 has been pushed to the Fedora 20 stable repository.