RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1020203 - socat: configure checks fail with some compilers
Summary: socat: configure checks fail with some compilers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: socat
Version: 7.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Paul Wouters
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
Depends On:
Blocks: 1019961 1085024
TreeView+ depends on / blocked
 
Reported: 2013-10-17 09:32 UTC by Florian Weimer
Modified: 2018-11-13 10:57 UTC (History)
4 users (show)

Fixed In Version: 1.7.3.1-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-13 10:57:07 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2013-10-17 09:32:02 UTC
socat specifies -Werror when running some of its configure checks, and uses code that generates warnings (which are turned into errors).  This is extremely brittle because the code snippets used for checking tend to generate other warnings as well, rendering the checks ineffective.

An example is the AC_BASIC_TYPE macro below.  Some compilers warn about the useless comparison &u==&v, it seems.  GCC might do so eventually, too, so this is really brittle and should be fixed.

dnl find what physical type (basic C type) is equivalent to the given type.
dnl arg1: include file(s)
dnl arg2: type name
dnl arg3: output variable
dnl arg4: cache variable (might be constructed automatically)
dnl   output values: 1..short, 2..unsigned short, 3..int, 4..u-int,
dnl                  5..long, 6..u-long; others not yet supported
define(AC_BASIC_TYPE,[
AC_CACHE_CHECK(for equivalent simple type of $2, $4,
[CFLAGS1="$CFLAGS"; CFLAGS="$ERRONWARN $(echo "$CFLAGS1" | sed -e 's@-Wall@@g')"
 AC_TRY_COMPILE([$1],[$2 u; short v; &u==&v;],
 [$4="1 /* short */"],
 [AC_TRY_COMPILE([$1],[$2 u; unsigned short v; &u==&v;],
  [$4="2 /* unsigned short */"],
  [AC_TRY_COMPILE([$1],[$2 u; int v; &u==&v;],
   [$4="3 /* int */"],
   [AC_TRY_COMPILE([$1],[$2 u; unsigned int v; &u==&v;],
    [$4="4 /* unsigned int */"],
    [AC_TRY_COMPILE([$1],[$2 u; long v; &u==&v;],
     [$4="5 /* long */"],
     [AC_TRY_COMPILE([$1],[$2 u; unsigned long v; &u==&v;],
      [$4="6 /* unsigned long */"],
      [AC_TRY_COMPILE([$1],[$2 u; long long v; &u==&v;],
       [$4="7 /* long long */"],
       [AC_TRY_COMPILE([$1],[$2 u; unsigned long long v; &u==&v;],
        [$4="8 /* unsigned long long */"],
        [$4="0 /* unknown, taking default */"
]) ]) ]) ]) ]) ]) ]) ])
 CFLAGS="$CFLAGS1" ])
AC_DEFINE_UNQUOTED($3, ${$4})
])

Comment 2 Gerhard 2014-03-10 21:04:58 UTC
Has been significantly improved in upstream release 1.7.2.4

Comment 5 Paul Wouters 2016-04-28 04:32:28 UTC
Florian: can you check 1.7.3.1 and let me know if that solves it satisfactory? Since I'd like to rebase to that version

Comment 6 Florian Weimer 2016-04-28 05:35:25 UTC
(In reply to Paul Wouters from comment #5)
> Florian: can you check 1.7.3.1 and let me know if that solves it
> satisfactory? Since I'd like to rebase to that version

I don't see -Werror in configure checks with socat 1.7.3.1.

Comment 7 Paul Wouters 2018-11-13 10:57:07 UTC
This bug is addressed by ERRATA RHBA-2017:2049-03 socat bug fix update

https://errata.devel.redhat.com/advisory/26967


Note You need to log in before you can comment on or make changes to this bug.