Bug 1020760 - [notifier] sent notification should be visible in INFO log level
Summary: [notifier] sent notification should be visible in INFO log level
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-notification-service
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.4.0
Assignee: Mooli Tayer
QA Contact: Pavel Stehlik
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-18 09:07 UTC by Jiri Belka
Modified: 2016-02-10 19:14 UTC (History)
7 users (show)

Fixed In Version: ovirt-3.4.0-alpha1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 20861 0 None None None Never

Description Jiri Belka 2013-10-18 09:07:59 UTC
Description of problem:
If I don't have DEBUG in /etc/ovirt-engine/notifier/log4j.xml I cannot see what notifications notifier has sent.

Please make basic info in INFO log level. It's not important to see whole mail body but subject and to whom would be enough.

FYI, INFO is default log level. Thus one could be surprise that nothing is logged. I believe INFO is about actual actions of a component and thus in this context it should be seen what notifier is notifying about.

Version-Release number of selected component (if applicable):
is19

How reproducible:
100%

Steps to Reproduce:
1. vm migration triggers an event, a user has mail
2. migrate vm
3. check notifier.log

Actual results:
real sending of events is not logged in INFO level

Expected results:
INFO = info about its main purpose functionality, thus in INFO I should see lines that something is sent soemewhere

Additional info:
fyi it is in debug

2013-10-18 10:56:45,027 DEBUG [org.ovirt.engine.core.notifier.utils.sender.mail.EventSenderMailImpl] Send email to [jbelka]
 subject:
 [Alert Notification. (jb-rh33.rhev.lab.eng.brq.redhat.com), [Migration started (VM: jb-w8-x86, Source: dell-r210ii-13, Destination: dell-r210ii-03, User: admin@internal).]]
 body:
 [Time:2013-10-18 10:55:03.305
Message:Migration started (VM: jb-w8-x86, Source: dell-r210ii-13, Destination: dell-r210ii-03, User: admin@internal).
Severity:0
User Name: admin@internal
VM Name: jb-w8-x86
Host Name: dell-r210ii-13
Template Name: Blank
Data Center Name: Default
]

Comment 1 Mooli Tayer 2013-11-04 13:34:51 UTC
patch proposed upstream.
log.info recipient and subject.
log.debug message body.

Comment 2 Sandro Bonazzola 2014-01-14 08:44:51 UTC
ovirt 3.4.0 alpha has been released

Comment 3 Jiri Belka 2014-01-27 09:59:30 UTC
ok, ovirt-engine-tools-3.4.0-0.2.master.20140112020439.git9ad8529.el6.noarch

2014-01-27 09:58:05,603 INFO  [org.ovirt.engine.core.notifier.utils.sender.mail.EventSenderMailImpl] Send email to [jbelka]
 subject:
 [Issue Solved Notification. (jb-rh34.rhev.lab.eng.brq.redhat.com), [Host dell-r210ii-13 was activated by admin@internal.]]

Comment 4 Itamar Heim 2014-06-12 14:07:42 UTC
Closing as part of 3.4.0


Note You need to log in before you can comment on or make changes to this bug.