Red Hat Bugzilla – Bug 1021244
Review Request: aspell-la - Latin dictionaries for Aspell
Last modified: 2013-11-10 01:56:30 EST
Spec URL: http://kupo.se/pub/review/aspell/aspell-la.spec
SRPM URL: http://kupo.se/pub/review/aspell/aspell-la-20020503-1.fc19.src.rpm
Description: Provides the word list/dictionaries for the following: Latin
Fedora Account System Username: opuk
Mostly similar to the aspell-fi review feedback:
No older/retired package or stalled review request with the same name could be located.
No other package includes conflicting files:
# repoquery --whatprovides /usr/lib64/aspell-0.60/la*
$ rpmls -p aspell-la-20020503-1.fc21.x86_64.rpm
The packaging style (e.g. arch-specific, deps, -debuginfo disabled) matches the other aspell-* packages.
aspell-la.x86_64: E: incorrect-fsf-address /usr/share/doc/aspell-la/COPYING
aspell-la.x86_64: E: incorrect-fsf-address /usr/share/doc/aspell-la/Copyright
With the last release being from 2002-2004, probably not much will happen related to that.
> License: GPLv2
The README points at file "Copyright" for the "exact terms", and that one contains the "or (at your option) any later version" clause. That would be "GPLv2+". However:
Considering that the GPLv3 has been released later than 2004, and the web page doesn't contain the "or later version" clause, the file Copyright is likely just a cut'n'paste error. aspell-cs for example gets it right and has dropped the "later version" clause.
Not a big issue, just need to point that out in the review, since there are licensing clarification guidelines. A comment in the spec file above the License tag would be good.
# Custom configure script, %configure cannot and need not be used.
So, no issues that need another build for review. About the extra comments and the URL, that's up to you and may be touched before/after importing the package into dist git.
New Package SCM Request
Package Name: aspell-la
Short Description: Latin dictionaries for Aspell
Branches: f18 f19 f20
Git done (by process-git-requests).
aspell-la-20020503-1.fc18 has been submitted as an update for Fedora 18.
aspell-la-20020503-1.fc19 has been submitted as an update for Fedora 19.
aspell-la-20020503-1.fc20 has been submitted as an update for Fedora 20.
aspell-la-20020503-1.fc20 has been pushed to the Fedora 20 testing repository.
aspell-la-20020503-1.fc18 has been pushed to the Fedora 18 stable repository.
aspell-la-20020503-1.fc19 has been pushed to the Fedora 19 stable repository.
aspell-la-20020503-1.fc20 has been pushed to the Fedora 20 stable repository.