Red Hat Bugzilla – Bug 1021343
[RHSC] - Stop rebalance confirmation dialog does not display the volumes on which rebalance is going to be stopped.
Last modified: 2015-05-13 12:28:58 EDT
Description of problem:
Stop rebalance confirmation dialog does not display the volumes on which rebalance is going to be stopped.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Create a volume and start rebalance on the volume.
2. Once rebalance is started click on the status dialog from the drop down menu.
3. Now click on the stop rebalance dialog .
4. Now it opens a confirmation dialog for stop rebalance.
In the cofirmation dialog it has the following text "Are you sure you want to stop the rebalance operation in following Volume(s)?"
With the text above it should display the volName on which rebalance is going to be stopped.
Make the text as "Are you sure you want to stop the rebalance operation on following Volume : <volume-name>?"
stop rebalance confirmation dialog is not consistent with other "stop" dialogs.
Attaching the current "stop rebalance confirmation dialog" and the correct "stop dialog screenshots".
Created attachment 829115 [details]
Current stop rebalance confirmation dialog
Created attachment 829116 [details]
Stop volume confirmation popup
This stop rebalance dialog is for a particular volume where as the stop volume confirmation popup is for a set of volumes. So how can we compare this with the one which shows multiple volume confirmation?
What I am referring to is, the difference in the way the confirmation question appears on the dialog. Looking at the two screenshots that I have attached, it is clear that, the stop rebalance confirmation is different from other confirmation dialogs seen in the UI.
The confirmation for stop volume, stop remove-brick etc., appears in the following way -
"Are you sure you want to stop the rebalance operation on following Volume?"
For stop rebalance, it appears as follows -
"Are you sure you want to stop the rebalance operation on following Volume : <volume-name>?"
Any reason for this being different from the others?
The attached screen shows: "Are you sure you want to stop the rebalance operation on the volume: <volume Name> ?
The reason is: This message is for a specific volume. As per the current design,
we can not operate stop rebalance for a set of volume like other stop operations.
So we can not (/need not) shows any list of volumes here!
That is why I removed the word "following" and the message comes with a single volume name.
It does not matter whether it is a single or multiple volumes. It should be consistent with all the other confirmation dialog in the console.
The current message is fine and lets not discuss it any further and waste time on this. Pls. move it to ON_QA.
verified in cb10 (rhsc-2.1.2-0.26.master.el6_5.noarch). Now the status dialog displays the volume name on which rebalance is going to be stopped. Attaching the screenshot for the same.
Created attachment 834722 [details]
Screen shot from cb10 build .
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.