Bug 1021958 - socat: length check in _xiodump()
Summary: socat: length check in _xiodump()
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: socat
Version: 7.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Paul Wouters
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
Depends On:
Blocks: 1019961 1085024
TreeView+ depends on / blocked
 
Reported: 2013-10-22 12:12 UTC by Florian Weimer
Modified: 2018-11-13 10:58 UTC (History)
3 users (show)

Fixed In Version: 1.7.3.1-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-13 10:58:54 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Florian Weimer 2013-10-22 12:12:15 UTC
_xiodump() in xio-ascii.c has questionable length check and needs to compare against (codlen - 1) / 3, not 2 * codlen + 1.  It also should cap the input length at that value.  (3 characters per byte in case of interleaving spaces.)  codlen must be at least 1 (assert?).  xiodump() can write beyond the end of the buffer, but its callers compensate for that by not including the NUL byte in the passed size.

Comment 2 Gerhard 2014-03-10 21:07:55 UTC
Has been fixed in upstream release 1.7.2.4

Comment 5 Paul Wouters 2018-11-13 10:58:54 UTC
This bug is addressed by ERRATA RHBA-2017:2049-03 socat bug fix update

https://errata.devel.redhat.com/advisory/26967


Note You need to log in before you can comment on or make changes to this bug.