Bug 1022106 - itext: remove versioned jars from %{_javadir}
Summary: itext: remove versioned jars from %{_javadir}
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: itext
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1022024
TreeView+ depends on / blocked
 
Reported: 2013-10-22 15:44 UTC by Stanislav Ochotnicky
Modified: 2014-03-12 11:23 UTC (History)
4 users (show)

Fixed In Version: 2.1.7-25
Clone Of:
Environment:
Last Closed: 2014-03-12 11:23:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Proposed patch (3.11 KB, patch)
2013-11-07 14:34 UTC, Mikolaj Izdebski
no flags Details | Diff

Description Stanislav Ochotnicky 2013-10-22 15:44:12 UTC
Package itext seems to contain versioned jar files in %{_javadir}
(/usr/share/java). Such versioned files cause problems for automatic
requires generation and violate packaging guidelines[1].

List of subpackages and contained versioned jars
itext-toolbox:
/usr/share/java/itext-toolbox-2.1.7.jar
itext-rups:
/usr/share/java/itext-rups-2.1.7.jar
itext-rtf:
/usr/share/java/itext-rtf-2.1.7.jar
itext-core:
/usr/share/java/itext-2.1.7.jar


There are cases where this can be a false positive. Most likely if:
   * your package is compatibility version and contains only versioned
     jars
   * your package has version in the name of jars that are part of
     package name

Thank you,

[1] https://fedoraproject.org/wiki/Packaging:Java#Filenames

Comment 1 gil cattaneo 2013-10-22 17:40:44 UTC
is still required required by pdftk package?

Comment 2 Mikolaj Izdebski 2013-11-07 14:34:21 UTC
Created attachment 821175 [details]
Proposed patch

Comment 3 gil cattaneo 2013-11-07 19:32:19 UTC
thanks for the patch, but gcj bit are required by pdftk package,
and i don't know, if removing versioned JARs, after aot-compile-rpm
work properly..

Comment 4 Mikolaj Izdebski 2013-11-08 08:16:49 UTC
In currect state itext violates packaging guidelines.
It also breaks maven-doxia, see:
https://lists.fedoraproject.org/pipermail/devel/2013-November/191711.html

GCJ parts can stay, butversioned JARs need to be removed.

Comment 5 Stanislav Ochotnicky 2013-11-22 15:12:13 UTC
This should be merged to F20 as well. I will likely do so next week

Comment 6 Mikolaj Izdebski 2014-03-12 11:23:31 UTC
I believe that this bug is fixed in itext-2.1.7-25,
which is available in Fedora Rawhide, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=503897


Note You need to log in before you can comment on or make changes to this bug.