Bug 1022133 - libguestfs: remove versioned jars from %{_javadir}
libguestfs: remove versioned jars from %{_javadir}
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: libguestfs (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Richard W.M. Jones
Fedora Extras Quality Assurance
:
Depends On: 1022184
Blocks: 1022024
  Show dependency treegraph
 
Reported: 2013-10-22 11:48 EDT by Stanislav Ochotnicky
Modified: 2013-10-22 16:56 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1022184 (view as bug list)
Environment:
Last Closed: 2013-10-22 16:56:50 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Stanislav Ochotnicky 2013-10-22 11:48:23 EDT
Package libguestfs seems to contain versioned jar files in %{_javadir}
(/usr/share/java). Such versioned files cause problems for automatic
requires generation and violate packaging guidelines[1].

List of subpackages and contained versioned jars
libguestfs-java:
/usr/share/java/libguestfs-1.22.6.jar
/usr/share/java/libguestfs-1.22.6.jar


There are cases where this can be a false positive. Most likely if:
   * your package is compatibility version and contains only versioned
     jars
   * your package has version in the name of jars that are part of
     package name

Thank you,

[1] https://fedoraproject.org/wiki/Packaging:Java#Filenames
Comment 1 Richard W.M. Jones 2013-10-22 12:17:41 EDT
I don't really know about Java.  However it looks as if just
renaming the jar as %{name}.jar is sufficient, right?  Just
renaming it won't break anything?
Comment 2 Stanislav Ochotnicky 2013-10-22 12:59:32 EDT
Huh, that must be one of weirder packaging issues I've seen in a long time :-0 

Yes, your jar file should not have version in it otherwise applications using symlinks will break if the version changes.

Simple rename will do. libguestfs-java is not required by anything (yet) so it definitely won't cause any issues.
Comment 3 Richard W.M. Jones 2013-10-22 16:56:50 EDT
I fixed this in Rawhide:

commit b4fb93fa540a7c29092ae44dfe93b4ef907640cd
Author: Richard W.M. Jones <rjones@redhat.com>
Date:   Tue Oct 22 21:20:57 2013 +0100

    Don't use versioned jar file (RHBZ#1022133).

Not built yet.

Note You need to log in before you can comment on or make changes to this bug.