Bug 1022133 - libguestfs: remove versioned jars from %{_javadir}
Summary: libguestfs: remove versioned jars from %{_javadir}
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libguestfs
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1022184
Blocks: 1022024
TreeView+ depends on / blocked
 
Reported: 2013-10-22 15:48 UTC by Stanislav Ochotnicky
Modified: 2013-10-22 20:56 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1022184 (view as bug list)
Environment:
Last Closed: 2013-10-22 20:56:50 UTC
Type: ---


Attachments (Terms of Use)

Description Stanislav Ochotnicky 2013-10-22 15:48:23 UTC
Package libguestfs seems to contain versioned jar files in %{_javadir}
(/usr/share/java). Such versioned files cause problems for automatic
requires generation and violate packaging guidelines[1].

List of subpackages and contained versioned jars
libguestfs-java:
/usr/share/java/libguestfs-1.22.6.jar
/usr/share/java/libguestfs-1.22.6.jar


There are cases where this can be a false positive. Most likely if:
   * your package is compatibility version and contains only versioned
     jars
   * your package has version in the name of jars that are part of
     package name

Thank you,

[1] https://fedoraproject.org/wiki/Packaging:Java#Filenames

Comment 1 Richard W.M. Jones 2013-10-22 16:17:41 UTC
I don't really know about Java.  However it looks as if just
renaming the jar as %{name}.jar is sufficient, right?  Just
renaming it won't break anything?

Comment 2 Stanislav Ochotnicky 2013-10-22 16:59:32 UTC
Huh, that must be one of weirder packaging issues I've seen in a long time :-0 

Yes, your jar file should not have version in it otherwise applications using symlinks will break if the version changes.

Simple rename will do. libguestfs-java is not required by anything (yet) so it definitely won't cause any issues.

Comment 3 Richard W.M. Jones 2013-10-22 20:56:50 UTC
I fixed this in Rawhide:

commit b4fb93fa540a7c29092ae44dfe93b4ef907640cd
Author: Richard W.M. Jones <rjones@redhat.com>
Date:   Tue Oct 22 21:20:57 2013 +0100

    Don't use versioned jar file (RHBZ#1022133).

Not built yet.


Note You need to log in before you can comment on or make changes to this bug.