Bug 1022163 - SimplyHTML: remove versioned jars from %{_javadir}
Summary: SimplyHTML: remove versioned jars from %{_javadir}
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: simplyhtml
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1022024
TreeView+ depends on / blocked
 
Reported: 2013-10-22 15:53 UTC by Stanislav Ochotnicky
Modified: 2014-03-25 16:05 UTC (History)
2 users (show)

Fixed In Version: 0.16.7-3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-25 16:05:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Adapt to current packaging guidelines (3.74 KB, patch)
2014-01-07 11:53 UTC, Michael Simacek
no flags Details | Diff
Adapt to current packaging guidelines (3.74 KB, patch)
2014-03-25 09:59 UTC, Michael Simacek
no flags Details | Diff
Adapt to current packaging guidelines (3.95 KB, patch)
2014-03-25 13:42 UTC, Michael Simacek
no flags Details | Diff

Description Stanislav Ochotnicky 2013-10-22 15:53:19 UTC
Package SimplyHTML seems to contain versioned jar files in %{_javadir}
(/usr/share/java). Such versioned files cause problems for automatic
requires generation and violate packaging guidelines[1].

List of subpackages and contained versioned jars
SimplyHTML:
/usr/share/java/SimplyHTML/SimplyHTML-0.16.7.jar
/usr/share/java/SimplyHTML/SimplyHTML-help-0.16.7.jar
/usr/share/java/SimplyHTML/SimplyHTMLHelp-0.16.7.jar
/usr/share/java/SimplyHTML/simplyhtml-0.16.7.jar
/usr/share/java/SimplyHTML/simplyhtmlhelp-0.16.7.jar


There are cases where this can be a false positive. Most likely if:
   * your package is compatibility version and contains only versioned
     jars
   * your package has version in the name of jars that are part of
     package name

Thank you,

[1] https://fedoraproject.org/wiki/Packaging:Java#Filenames

Comment 1 Michael Simacek 2014-01-07 11:53:59 UTC
Created attachment 846624 [details]
Adapt to current packaging guidelines

Comment 2 Michael Simacek 2014-03-25 09:59:58 UTC
Created attachment 878365 [details]
Adapt to current packaging guidelines

Rebased

Comment 3 Mikolaj Izdebski 2014-03-25 13:39:47 UTC
symlink was changed to directory, this requires workaround for rpm bug:

    # Workaround for RPM bug #646523 - can't change symlink to directory
    # TODO: Remove this in F-23
    %pretrans javadoc -p <lua>
    dir = "%{_javadocdir}/%{name}"
    dummy = posix.readlink(dir) and os.remove(dir)
     
Michael, please update your patch.

Comment 4 Michael Simacek 2014-03-25 13:42:30 UTC
Created attachment 878465 [details]
Adapt to current packaging guidelines

Comment 5 Mikolaj Izdebski 2014-03-25 13:48:52 UTC
Fixed in SimplyHTML-0.16.7-3

Comment 6 Mikolaj Izdebski 2014-03-25 16:05:10 UTC
Built for rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=506856
Closing.


Note You need to log in before you can comment on or make changes to this bug.