Mark Drilling <mdrilling> made a comment on jira TEIIDDES-1895 On designer side, we load a collection of available 'types' via the adminApi call "getDataSourceTemplateNames()". Checking with teiid guys on whether the 'built in' types should still be included (even though not in standalone.xml), or we need to do something on designer side.
Ramesh Reddy <rareddy> made a comment on jira TEIIDDES-1895 If you remove the them from configuration then they are gone, so getDataSourceTemplateNames() will return null or empty list
Van Halbert <vhalbert> made a comment on jira TEIIDDES-1895 what will be returned when multiple (for 1 type) is defined in the configuration? Or is the types based on the name's, not the type, returned for display?
Van Halbert <vhalbert> made a comment on jira TEIIDDES-1895 what will be returned when multiple (for 1 type) is defined in the configuration? Or is the types based on the name's, not the type, returned for display? Also, can't guarantee the one's that are there will be there after the user deletes some and adds others.
Ramesh Reddy <rareddy> made a comment on jira TEIIDDES-1895 It is based on the names. If two of them are added by the user of same type, then they are represented as two separate resource adapters. the only way user deletes is manually editing the standalone.xml, in that regard they delete much more than that make system render useless and we have no control over it.
Van Halbert <vhalbert> made a comment on jira TEIIDDES-1895 There's a couple of issues here: - how are the empty resources adapters (no definitions) and one's that have something defined tracked for the users? Or is it relevant? - OOTB, the resource adapters have nothing defined for them, just empty resource-adapters for each specific type. So the first one added by the user in designer, Teiid added it to the existing resource-adapter. And when additional resource adapters for a type are to be added, Teiid knows that it has to add the module first, before specifying the definitions. (this isn't really an issue, more of just being clear as to what's happening between designer and teiid) - To use common CLI scripts, if multiple resource adapters are being setup for the same type, each needs to configure a separate resource adapter. And to use a common script, the add:module command needs to be used. Which means these can't be configured with the OOTH resource-adapters, because a duplicate exception is thrown, because one by that name already exists.
Ramesh Reddy <rareddy> made a comment on jira TEIIDDES-1895 - Empty resource-adapters are equal to "driver" name concept in the JDBC data sources side - Some of this is due to AS-4776 fix, that is what been suggested that we do I do not understand the issue you mentioned on CLI scripts. Note that this is all occurring when Designer is used to create RA, if you manually create and restart the server you can have single RA contains multiple connections of same type and there are no issues.
Van Halbert <vhalbert> made a comment on jira TEIIDDES-1895 Regarding CLI scripts, after realizing the issue where we don't want to add multiple entries to the same resource-adapter, I had to change all the CLI scripts in quick starts. Because its not known when someone will try to run a quick start, it has to be assumed that server could already have resource adapters configured. Therefore, I had to go back to the quick start CLI scripts and add the add:module command, which then also required that the names for each be different than the OOTB resource-adapter names. But as you said, it works as you said in Designer, so there doesn't appear to be an issue. So we can close this jira and close the related jira for removing the empty resource adapters.
Van Halbert <vhalbert> updated the status of jira TEIIDDES-1895 to Resolved
Van Halbert <vhalbert> made a comment on jira TEIIDDES-1895 This is not an issue.
Barry LaFond <blafond> updated the status of jira TEIIDDES-1895 to Closed