Bug 1022402 - qemu-kvm: patch application failure
Summary: qemu-kvm: patch application failure
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: qemu-kvm
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Miroslav Rezanina
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-23 08:32 UTC by Florian Weimer
Modified: 2013-10-24 10:16 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-10-24 10:16:36 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Florian Weimer 2013-10-23 08:32:12 UTC
A build of 6799d4487cf8a70b877ae8dcf3c44e399a9ca5ac / 1.5.3-10.el7 triggers this error:

Patch #37 (change-path-from-qemu-to-qemu-kvm.patch):
+ echo 'Patch #37 (change-path-from-qemu-to-qemu-kvm.patch):'
+ /usr/bin/cat /builddir/build/SOURCES/change-path-from-qemu-to-qemu-kvm.patch
+ /usr/bin/patch -p1 --fuzz=0
patching file os-posix.c
can't find file to patch at input line 25
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/redhat/qemu-kvm.spec.template b/redhat/qemu-kvm.spec.template
|index 84088eb..646eb1a 100644
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
patching file ui/vnc.c

It doesn't result in a build failure because standard input is /dev/null on the builders, and GNU patch treats an EOF as "yes" in this context.  Nevertheless, such a partially applied patch cannot be a good thing.

Comment 2 Miroslav Rezanina 2013-10-24 10:16:36 UTC
This is expected behavior. Skipped chunk is spec file change that is applied directly to spec file and not process during prep phase of rpmbuild.

This is cause by using exploded git as source for patch file and has no effect to build result. If you check patch file mentioned in your error, chunk is empty in the patch file. It could be removed but we use this as reminder that spec file has been changed.


Note You need to log in before you can comment on or make changes to this bug.