Created attachment 815471 [details] sample jsp file Description of problem: The version of jbossweb 7.2.0.GA includes an inconsistent name for enabling char array type rather than using String. Version-Release number of selected component (if applicable): 7.2.0.GA How reproducible: Always. Steps to Reproduce: 1. Deploy a web application with a really simple Hello World JSP. Use a browser to request the JSP. Add server configuration to enable the use of char array. <configuration> <jsp-configuration generate-strings-as-char-arrays="true"/> </configuration> 2. Inspect generated source code for the Servlet (generated from the JSP). Hint: see the code starting with out.write( Actual results: String type is used to hold the jsp character data used to generate a response. Expected results: char array is used to hold jsp character data used to generate a response. Additional info:
This is needed to acquire the fix to JBWEB-282 as well to avoid potential hangs in concurrent deployments.
Some clarification. Web 7.3 is a copy of the 7.2 branch (which is for EAP 6.1) with no additional changes, for EAP 6.2 maintenance if needed. Web 7.4 is for EAP 6.3 (websockets + Servlet 3.1 upgrade).
Jeremy Whiting <jwhiting> made a comment on jira JBWEB-281 Looking at the tagged version of code in FishEye the code has not been patched. https://source.jboss.org/browse/JBossWeb/tags/JBOSSWEB_7_3_0_FINAL/src/main/java/org/apache/jasper/EmbeddedServletOptions.java?r=2086&r=2288&r=2288&r=2086#to534 Yet in the SVN repo the code is updated. Did the tagging task happen too early ? http://anonsvn.jboss.org/repos/jbossweb/branches/7.3.x/src/main/java/org/apache/jasper/EmbeddedServletOptions.java The 7.3.0.Final library included in EAP 6.2 CR3 does not fix this issue.
Jeremy Whiting <jwhiting> updated the status of jira JBWEB-281 to Reopened
Jeremy Whiting <jwhiting> made a comment on jira JBWEB-281 The 7.3.0 library does not fix the issue. See comments about the tagged version of code.
Please, less spam ... The tag uses the "genStringAsCharArray" init param (avoiding your weird comparison URL): http://anonsvn.jboss.org/repos/jbossweb/tags/JBOSSWEB_7_3_0_FINAL/src/main/java/org/apache/jasper/EmbeddedServletOptions.java
Yes you are right, the tagged code does have the fix. Thanks for that. The FishEye page I used is showing incorrect information.
Jeremy Whiting <jwhiting> updated the status of jira JBWEB-281 to Resolved
Marking for inclusion in 6.2.1 release notes documentation.
Verified in 6.2.1.CP.CR1-patch
I have marked this ticket as possibly needing a release notes entry on QE's advice. As this component upgrade resolves several issues, the RN items would appear under the label "Bug Fixes".