RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:

fs-lib.sh's is_alive function attempts to determine if a filesystem resource is healthy by writing and reading a file from disk.  The method used to pick the file name involves a infinite loop where we try different file names until we get one that doesn't exist.  We don't need to be doing that... Instead we should create a unique filename based on the resource's instance name and use that for testing.

Created attachment 815990 [details]
optimize fs monitoring with mktemp for write testing

This patch removes the loop for a single call to mktemp.

+		file=$(mktemp "$mount_point/check_writable.XXXXXX")

best if file is hidden and contains the hostname /.check_writable.$(hostname).XXXXXX

this avoid a potential problem for clusterfs without posix locks where two nodes could theoretically create the same file.

Created attachment 816216 [details]
optimize fs monitoring with mktemp for write testing

uploaded new patch that makes file hidden and includes hostname

Unit testing.

No special case needs to be verified for this. This is an optimization. Sanity checking that a fs-lib.sh based file system resource (such as fs.sh) can properly start, monitor, and stop a filesystem is enough.  No behavior change is expected.

-- Vossel

I have verified that the filesystem resource behaves as expect  with 
resource-agents-3.9.2-47.el6.x86_64.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1428.html