Red Hat Bugzilla – Bug 1023447
Keyboard shortcuts not working properly when started using SpiceX
Last modified: 2014-01-21 09:47:32 EST
Description of problem:
Keyboard shortcuts, that should be intercepted by the client, don't work when started using SpiceX on Windows clients. And they are not added to the menu either
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Connect to a VM using SpiceX plugin from browser
The Send Key menu item has no shortcuts for certain combinations, also those combinations aren't added to the end of the list
it should behave the same as when started using a file
Please get the G_MESSAGES_DEBUG=GSpiceController log.
Could you try with SpiceX test page?
there is a difference between using hotkeys with controller and vv file,
With the controller, only the hotkeys being set will be enabled, while the other will remain disable (done in app_set_hotkeys). While the vv file will enable all accels and modify the binding (hotkey_set_binding)
- currently, to enable c-a-end with controller, you'll need a secure-attention hotkey set
- if think we should keep controller behaviour and disable hotkeys that aren't sepcified
We could move the code to disable all hotkeys in a seperate function and call it when loading the vv file, see attached patch
Created attachment 817176 [details]
(In reply to Marc-Andre Lureau from comment #9)
> - currently, to enable c-a-end with controller, you'll need a
> secure-attention hotkey set
> - if think we should keep controller behaviour and disable hotkeys that
> aren't sepcified
I don't think that's entirely a smart idea. It looks like customers pretty much demand to have an option to send Ctrl-alt-del using keyboard (#1004440). I'd say it'd be better to add an exception for this keyboard shortcut for windows client and set it every time.
I propose we have the same behaviour between command line, controller and file settings: only enable global bindings if they are explicitely set on command line.
I believe the default setup should keep the strict minimal global bindings (ungrab when mouse is grabbed). The send key menu is enough to circunvent OS/window manager keybinding filtering. That way full regular hw key input control is given to the guest.
moving to POST with the proposed patch
(In reply to Marc-Andre Lureau from comment #17)
> I propose we have the same behaviour between command line, controller and
> file settings: only enable global bindings if they are explicitely set on
> command line.
grr, I should reread myself 10x.. "only enable global bindings if they are explicitely set", by controller, cmd line, or config file.
> I believe the default setup should keep the strict minimal global bindings
> (ungrab when mouse is grabbed). The send key menu is enough to circunvent
> OS/window manager keybinding filtering. That way full regular hw key input
> control is given to the guest.
> moving to POST with the proposed patch
pushing to 3.4 as no blocker flag proposed and we are at RC phase. if
the bug should be fixed for 3.3.0, please request a blocker flag on it.
patches added to mingw-virt-viewer-0.5.6-16.el6_5
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.