Bug 1023860 - 'rpc/virnetmessage.c:348:33: error: too few arguments to function call' during home-brew compile in MacOS 10.9
Summary: 'rpc/virnetmessage.c:348:33: error: too few arguments to function call' durin...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: x86_64
OS: Mac OS
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-28 06:40 UTC by Ray Gomez
Modified: 2013-12-16 16:06 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-12-16 16:06:21 UTC
Embargoed:


Attachments (Terms of Use)
compile output (271.74 KB, text/plain)
2013-10-28 06:40 UTC, Ray Gomez
no flags Details

Description Ray Gomez 2013-10-28 06:40:27 UTC
Created attachment 816701 [details]
compile output

Description of problem:

Compile time problems:

  CC       rpc/libvirt_net_rpc_la-virnetmessage.lo
brew: superenv removed: -I/usr/include/libxml2 -W -Waddress -Wall -Warray-bounds -Wattributes -Wbad-function-cast -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wcomment -Wcomments -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wextra -Wformat-extra-args -Wformat-security -Wformat-y2k -Wformat-zero-length -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Winline -Wint-to-pointer-cast -Winvalid-pch -Wmain -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-prototypes -Wmultichar -Wnarrowing -Wnested-externs -Wnonnull -Wold-style-definition -Woverflow -Wparentheses -Wpointer-arith -Wpointer-sign -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes -Wswitch -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wno-missing-field-initializers -Wno-sign-compare -Wno-format-nonliteral -Wframe-larger-than=4096 -g -O2
brew: superenv added: -pipe -w -Os -march=native -isystem/usr/local/include -isystem/usr/include/libxml2 -isystem/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -isystem/System/Library/Frameworks/Python.framework/Versions/2.7/Headers
brew: superenv removed: -I/usr/include/libxml2 -W -Waddress -Wall -Warray-bounds -Wattributes -Wbad-function-cast -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wcomment -Wcomments -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wextra -Wformat-extra-args -Wformat-security -Wformat-y2k -Wformat-zero-length -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Winline -Wint-to-pointer-cast -Winvalid-pch -Wmain -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-prototypes -Wmultichar -Wnarrowing -Wnested-externs -Wnonnull -Wold-style-definition -Woverflow -Wparentheses -Wpointer-arith -Wpointer-sign -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes -Wswitch -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wno-missing-field-initializers -Wno-sign-compare -Wno-format-nonliteral -Wframe-larger-than=4096 -g -O2
brew: superenv added: -pipe -w -Os -march=native -isystem/usr/local/include -isystem/usr/include/libxml2 -isystem/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -isystem/System/Library/Frameworks/Python.framework/Versions/2.7/Headers
  CC       rpc/libvirt_net_rpc_la-virnetsocket.lo
rpc/virnetmessage.c:348:33: error: too few arguments to function call, expected
      3, have 2
    while (!(*filter)(&xdr, data)) {
            ~~~~~~~~~           ^
rpc/virnetmessage.c:404:30: error: too few arguments to function call, expected
      3, have 2
    if (!(*filter)(&xdr, data)) {
         ~~~~~~~~~           ^
2 errors generated.
make[3]: *** [rpc/libvirt_net_rpc_la-virnetmessage.lo] Error 1
make[3]: *** Waiting for unfinished jobs....

Version-Release number of selected component (if applicable):

1. 1.1.3 (seems any version > 1.0.2)

How reproducible:

Every time


Steps to Reproduce:
1. Homebrew install libvirt 1.0.2+ on MacOS 10.9 (Mavericks)

Actual results:  Compile Failure
Expected results:  Successful Compile
Additional info: N/A

Comment 1 Daniel Berrangé 2013-10-29 13:34:25 UTC
Fix posted upstream

https://www.redhat.com/archives/libvir-list/2013-October/msg01157.html

Comment 2 redhat 2013-10-29 18:31:40 UTC
We at MacPorts are also awaiting the solution to this problem (see https://trac.macports.org/ticket/41035) but the patch linked to above does not fix it.

Comment 3 Dave Allan 2013-10-29 21:43:48 UTC
(In reply to redhat from comment #2)
> We at MacPorts are also awaiting the solution to this problem (see
> https://trac.macports.org/ticket/41035) but the patch linked to above does
> not fix it.

You should mention what you're seeing on the upstream libvir-list if you haven't already, as I'm not sure that the folks who work on Mac follow bugzilla too closely.

Comment 4 Doug Goldstein 2013-11-01 00:57:22 UTC
The two proposed fixes are:

https://www.redhat.com/archives/libvir-list/2013-October/msg01254.html
https://www.redhat.com/archives/libvir-list/2013-October/msg01153.html

The first being the patch I integrated into Homebrew. I'd recommend MacPorts use that version as the 2nd one requires an autoreconf, which presently does not work on Mac OS X.

Comment 5 Cole Robinson 2013-12-16 16:06:21 UTC
Fixes are upstream now


Note You need to log in before you can comment on or make changes to this bug.