Bug 1024818 - please, stop catching all Exception instances and re-throwing them as DeviceCreateError
Summary: please, stop catching all Exception instances and re-throwing them as DeviceC...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-blivet
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David Lehman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1024116
TreeView+ depends on / blocked
 
Reported: 2013-10-30 13:28 UTC by Jakub Filak
Modified: 2016-12-01 00:45 UTC (History)
5 users (show)

Fixed In Version: python-blivet-1.2-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-29 16:32:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jakub Filak 2013-10-30 13:28:50 UTC
Description of problem:
create method of PartitionDevice class contains an 'except Exception' block [1] and inside of this block it raises a new instance of DeviceCreateError. This approach breaks ABRT's Duplicate search algorithm because all errors represented by descendants of Exception class are considered as single bug, since they all have equal back trace.


https://git.fedorahosted.org/cgit/blivet.git/tree/blivet/devices.py#n1559

Comment 1 David Lehman 2013-10-30 15:04:33 UTC
I'm sorry this is inconvenient from abrt's perspective, but it isn't as simple as re-raising any exception that we catch. That isn't manageable from the caller's perspective. I have plans to increase the granularity of the exceptions raised within blivet, but that is not a high priority in comparison with much of the other planned work.

Comment 2 Jakub Filak 2013-10-31 10:56:40 UTC
(In reply to David Lehman from comment #1)
From my point of view, this is inconvenient from user's perspective and maintainer's perspective. I have filed this bug report on behalf of all reporters which you have asked to open a separate bug report because the duplicate comment added by abrt was unrelated to the original report (i.e. bug 1021507 comment 20).

Just for the clarification: you will refine the granularity, but it has low priority

Comment 3 Fedora End Of Life 2015-05-29 09:39:30 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 David Lehman 2015-05-29 16:32:41 UTC
Will be fixed in F23.


Note You need to log in before you can comment on or make changes to this bug.