Bug 1026445 - [EL5] ovirt-guest-agent should load acpiphp module on start [NEEDINFO]
Summary: [EL5] ovirt-guest-agent should load acpiphp module on start
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-guest-agent
Version: unspecified
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
: 3.5.0
Assignee: Vinzenz Feenstra [evilissimo]
QA Contact: yeylon@redhat.com
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-04 16:31 UTC by amedeo
Modified: 2016-04-18 06:58 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-12 08:56:57 UTC
oVirt Team: Virt
michal.skrivanek: needinfo? (amedeo)


Attachments (Terms of Use)

Description amedeo 2013-11-04 16:31:21 UTC
Description of problem:
ovirt-guest-agent should load acpiphp module on service start due to hotplug / unplug PCI device like block device -> /dev/vdX

Version-Release number of selected component (if applicable):
[root@client01 ~# rpm -qa | egrep 'rhev|ovirt'
rhevm-guest-agent-1.0.7-10.el5ev
[root@client01 ~# rpm -qa | grep release-5
redhat-release-5Server-5.10.0.4


How reproducible:
Always

Steps to Reproduce:
1. Install rhel5 VM
2. add rhel-i386-rhev-agent-5-server channel (for 32bit rhel5
3. yum install rhevm-guest-agent -y
4. service ovirt-guest-agent restart
5. lsmod | grep acpiphp --> none output


Actual results:
ovirt-guest-agent won't load acpiphp module

Expected results:
ovirt-guest-agent should load acpiphp module if it's hasn't yet loaded

Comment 1 Itamar Heim 2014-01-12 08:43:29 UTC
setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.

Comment 2 Michal Skrivanek 2014-02-14 14:38:08 UTC
what PCI block device hotplug A host passthrough using a vdsm hook for this? Or regular "hotplug disk" via UI?

is this RHEV or oVirt?

Comment 3 amedeo 2014-02-14 15:40:42 UTC
(In reply to Michal Skrivanek from comment #2)
> what PCI block device hotplug A host passthrough using a vdsm hook for this?
> Or regular "hotplug disk" via UI?

regular hotplug disk

> 
> is this RHEV or oVirt?

it was opened for rhev but I think it's the same for ovirt and EL5 VMs (like centos5), so if you don't load (manually at this moment) acpiphp module on el5 vm, you can assign a new disk on web UI, but you must reboot the vm itself to scan / see the disk:

https://access.redhat.com/site/solutions/37774

Comment 4 Vinzenz Feenstra [evilissimo] 2014-03-31 07:15:44 UTC
(In reply to amedeo from comment #3)
> (In reply to Michal Skrivanek from comment #2)
> > what PCI block device hotplug A host passthrough using a vdsm hook for this?
> > Or regular "hotplug disk" via UI?
> 
> regular hotplug disk
> 
> > 
> > is this RHEV or oVirt?
> 
> it was opened for rhev but I think it's the same for ovirt and EL5 VMs (like
> centos5), so if you don't load (manually at this moment) acpiphp module on
> el5 vm, you can assign a new disk on web UI, but you must reboot the vm
> itself to scan / see the disk:
> 
> https://access.redhat.com/site/solutions/37774

Honestly I am not sure that this would be a good solution in general. First of all you have to install the oVirt guest agent and the RHEVM guest agent anyway. When you install them you can also install the acpiphp module and configure the OS to make it load the module on startup.
Having such a specific workaround for RHEL5 is in my opinion not any helpful. It is a nice thing to know that we could support disk hotplugging but if you are using an older OS and you want to use such a feature then the OS must be configured to support it anyway.

From my PoV this feature is not really worth it for such a specialized task where this is actually the administrators thing to decide.


Note You need to log in before you can comment on or make changes to this bug.