Created attachment 819463 [details] Can't upload this image to ccms with chrome Description of problem: Uploading attached image results in error message with chrome (upload successful with firefox). Error Message: Uncaught exception was detected. Redirecting you to the home page. Exception: (RangeError) : Maximum call stack size exceeded Version-Release number of selected component (if applicable): Build 201310180711
Actually, now doing an image search show that it did upload successfully despite the chrome message, return to main page and spinning wheel of doom!
Example of another image is [4271] Cen_wizoffline.png.
This is a known issue in Chrome. Firefox is unaffected. Will have to find workaround for Chrome users.
Created attachment 849118 [details] Image that can't be uploaded in Firefox or Chrome Alexandra Settle sent me this image and she wasn't able to upload it using Chrome or Firefox. I tried myself using Chrome 31 and Firefox 25 and it didn't work for me either. For reference the error on Firefox was: Uncaught exception was detected. Redirecting you to the home page. Exception: (RangeError) : arguments array passed to Function.prototype.apply is too large
Fixed in 1.8-SNAPSHOT build 201406251649. This was actually creating the images correctly. The problem however was in our clone method when the object was returned and was attempting to be displayed. Since chrome (and firefox on larger files) have issues copying large arrays (see https://code.google.com/p/google-web-toolkit/issues/detail?id=8239), I've altered the way we do the clone so that the byte array isn't cloned. This means that the two items will reference the same object in memory, but given that the only way we alter that value via the UI is to send new data to the REST API and then replace the old value, this isn't an issue.
Note: Matt has merged the changes into restyle and uploaded them to the test/development server.
Created attachment 913968 [details] Big image
Created attachment 913969 [details] Really big image
Confirmed that bulk image uploading and uploading individual images in Chrome and Firefox works with the supplied sample cases. I also successfully uploaded an image 1.2 MB big. Really large images (around 6 MB) failed, but that is most likely another bug (see BZ#1112937).