Hide Forgot
Description of problem: We have disable removeable for passthrough cdrom (scsi-block) and remove the locked and tray-open from HMP monitor infos in bug 890011. Lock status is not visible in "info block" for scsi-block, because it is not being emulated by QEMU. But there are still has <"locked": false> in QMP monitor, so i think we should remove it. Version-Release number of selected component (if applicable): host info: 2.6.32-425.el6.x86_64 qemu-kvm-rhev-0.12.1.2-2.415.el6.x86_64 seabios-0.6.1.2-28.el6.x86_64 guest info: 2.6.32-425.el6.x86_64 How reproducible: 100% Steps to Reproduce: 1.insert a DVD or CD to host. 2.boot guest with this DVD/CD passthrough via scsi-block interface. e.g:...-qmp tcp:0:4444,server,nowait -drive file=/dev/sr0,if=none,id=drive-cdrom-disk,format=raw,media=cdrom,cache=none,aio=native -device virtio-scsi-pci,bus=pci.0,addr=0x7,id=scsi0 -device scsi-block,drive=drive-cdrom-disk,id=cdrom-disk,bus=scsi0.0 3.compare the block info between HMP and QMP monitor. (qemu) info block {"execute":"query-block"} Actual results: after step 3, - HMP: (qemu) info block ... drive-cdrom-disk: removable=0 io-status=ok file=/dev/sr0 ro=1 drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0 - QMP: {"execute":"query-block"} {"return": [...{"io-status": "ok", "device": "drive-cdrom-disk", "locked": false, "removable": false, "inserted": {"iops_rd": 0, "iops_wr": 0, "ro": true, "drv": "raw", "iops": 0, "bps_wr": 0, "encrypted": false, "bps": 0, "bps_rd": 0, "file": "/dev/sr0"}, "type": "unknown"}...]} Expected results: we should remove the <"locked": false> from QMP monitor. Additional info:
Also tried the passthrough hard disk which hit the same issue. e.g:...-drive file=/dev/sdb,if=none,id=drive-disk,format=raw,media=disk,cache=none,aio=native -device virtio-scsi-pci,bus=pci.0,addr=0x7,id=scsi0 -device scsi-block,drive=drive-disk,id=disk,bus=scsi0.0 (qemu) info block ... drive-disk: removable=0 io-status=ok file=/dev/sdb ro=0 drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0 {"execute":"query-block"} {"return": [...{"io-status": "ok", "device": "drive-disk", "locked": false, "removable": false, "inserted": {"iops_rd": 0, "iops_wr": 0, "ro": false, "drv": "raw", "iops": 0, "bps_wr": 0, "encrypted": false, "bps": 0, "bps_rd": 0, "file": "/dev/sdb"}, "type": "unknown"}...]} Best Regards, sluo
For historical reasons, the "locked" field in the output of "query-block" is mandatory. It will even be present in hard disks, for example (unlike tray-open). So it cannot be removed.