Description of problem: It seems that cl.hpp includes platform dependant headers. This prevents the usage of opencl apps on non x86 arches. E.g. arm. E.g.: https://koji.fedoraproject.org/koji/taskinfo?taskID=6143396 Version-Release number of selected component (if applicable): f19 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: In file included from /usr/include/CL/cl.hpp:215:0, from /builddir/build/BUILD/ocltoys-39c5bb1b3c2a/common/opencl.h:32, from /builddir/build/BUILD/ocltoys-39c5bb1b3c2a/common/utils.h:25, from /builddir/build/BUILD/ocltoys-39c5bb1b3c2a/common/ocltoy.h:25, from /builddir/build/BUILD/ocltoys-39c5bb1b3c2a/common/ocltoy.cpp:29: /usr/lib/gcc/i686-redhat-linux/4.8.2/include/emmintrin.h:31:3: error: #error "SSE2 instruction set not enabled" # error "SSE2 instruction set not enabled" ^
Seems to be a problem of the upstream khronos headers: http://krblogs.com/post/64565799647/opencl-on-arm-linux mabye we should point this out to khronos. Why the heck are arch specific bits included in that header!? ...
Created attachment 889553 [details] Patch to make headers usable on arm This patch is needed to build any opencl app on arm
Hi, (In reply to Fabian Deutsch from comment #2) > Created attachment 889553 [details] > Patch to make headers usable on arm > > This patch is needed to build any opencl app on arm Your attachment seems to be missing the arm-nosse2.patch it introdices. Regards, Hans
Created attachment 889565 [details] Second try to attach the commit
Hey Hans, thanks - updated the patch. I believe that bugzilla stripped some parts from the first patch. Attahced it as plain text now.
Thanks, looks good now, I would say go ahead and commit + build it for rawhide, and then git merge f20 and f19 to master, and build them too.
Yep - that is what I want to do. Can you grant me the permissions in pkgdb - or can ths only be done by airlied?
That can only be done by airlied I'm afraid.
Hah. That patch did not work! It was a bit tricky to figure out why it did not. The problem is that in this package we don't have a build root where all the sources are. What I do now is, I install the files and apply the patch after installation. (still in %install, not in some %post).
opencl-headers-1.2-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/opencl-headers-1.2-4.fc20
opencl-headers-1.2-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/opencl-headers-1.2-4.fc19
> The problem is that in this package we don't have a build root where all the > sources are. You are confusing the term "buildroot" with "builddir". The underlying problem with the current spec is that %prep is empty. You could %setup an empty builddir as normal, copy the sources into that builddir, then %patch the files in the builddir as normal, and copy the final files into the %buildroot in %install.
(In reply to Michael Schwendt from comment #12) > > The problem is that in this package we don't have a build root where all the > > sources are. > > You are confusing the term "buildroot" with "builddir". Yes, I probably mixed up builddir and -root. > The underlying problem with the current spec is that %prep is empty. You > could %setup an empty builddir as normal, copy the sources into that > builddir, then %patch the files in the builddir as normal, and copy the > final files into the %buildroot in %install. Yes, I considered this (setting up a builddir using %setup). But I did not see a benefit in doing this intermediate step. Furthermore I was not sure if I could use %setup without a tarball.
%setup -T -c http://www.rpm.org/max-rpm-snapshot/s1-rpm-inside-macros.html
Hi, I've to side with Michael here, patching files in %install is just very very ugly, can you please fix things to do this properly ? Thanks, Hans
Hey Hans and Michael, I didn't get that Michael's comment was aimed at me to change it and use a builddir. But now that this was made clear - I'm happy to do so :)
Package opencl-headers-1.2-5.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing opencl-headers-1.2-5.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-5613/opencl-headers-1.2-5.fc20 then log in and leave karma (feedback).
opencl-headers-1.2-5.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
opencl-headers-1.2-5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.