Red Hat Bugzilla – Bug 1027889
adcli: avoid alloca in _adcli_ldap_have_in_mod
Last modified: 2016-11-04 02:21:38 EDT
In library/adldap.c:_adcli_ldap_have_in_mod(), there are two alloca calls:
vals = alloca (sizeof (struct berval) * (count + 1));
pvals = alloca (sizeof (struct berval *) * (count + 1));
Array allocation with alloca is problematic because that can lead to stack overflows. In this particular case, it seems to be harmless because count is always 1 (if I traced the callers correctly), but it still serves as a bad example.
Makes sense, but as you noted is non-critical. Bumping to next release. Will fix upstream in the meantime.
Fixed upstream, will be fixed by the rebase to 0.8.x.
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see email@example.com with any questions
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.