Bug 1027889 - adcli: avoid alloca in _adcli_ldap_have_in_mod
Summary: adcli: avoid alloca in _adcli_ldap_have_in_mod
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: adcli
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Sumit Bose
QA Contact: Stefan Dordevic
URL:
Whiteboard:
Depends On:
Blocks: 1027886
TreeView+ depends on / blocked
 
Reported: 2013-11-07 13:14 UTC by Florian Weimer
Modified: 2016-11-04 06:21 UTC (History)
3 users (show)

Fixed In Version: adcli-0.8.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-04 06:21:38 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
FreeDesktop.org 86970 0 None None None Never
Red Hat Product Errata RHBA-2016:2428 0 normal SHIPPED_LIVE adcli bug fix and enhancement update 2016-11-03 14:00:18 UTC

Description Florian Weimer 2013-11-07 13:14:44 UTC 
In library/adldap.c:_adcli_ldap_have_in_mod(), there are two alloca calls:

	vals = alloca (sizeof (struct berval) * (count + 1));
	pvals = alloca (sizeof (struct berval *) * (count + 1));

Array allocation with alloca is problematic because that can lead to stack overflows.  In this particular case, it seems to be harmless because count is always 1 (if I traced the callers correctly), but it still serves as a bad example.
Comment 2 Stef Walter 2013-11-08 09:03:39 UTC 
Makes sense, but as you noted is non-critical. Bumping to next release. Will fix upstream in the meantime.
Comment 4 Sumit Bose 2016-01-25 14:45:19 UTC 
Fixed upstream, will be fixed by the rebase to 0.8.x.
Comment 6 Mike McCune 2016-03-28 23:32:32 UTC 
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
Comment 11 errata-xmlrpc 2016-11-04 06:21:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2428.html
Note You need to log in before you can comment on or make changes to this bug.