Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1028071

Summary:	RPM packages contain source's JARs
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Pavel Janousek <pjanouse>
Component:	RPMs	Assignee:	Fernando Nasser <fnasser>
Status:	CLOSED NOTABUG	QA Contact:	Katerina Odabasi <kanovotn>
Severity:	high	Docs Contact:	Russell Dickenson <rdickens>
Priority:	unspecified
Version:	6.2.0	CC:	pgier
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-08 13:57:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Janousek 2013-11-07 15:35:46 UTC

There are RPM files contain not only JAR artifact as the equivalent from ZIP distro but artifact-sources.JAR as well. The list of affected RPM packages is a quite huge, but not all RPM packages are affected by this issue.

The good news is - these sources.JAR aren't referenced from /usr/share/jbossas/modules, so they are hidden for EAP instance itself.

The bad news are:
- they are deployed to /usr/share/java though
- affected RPM packages are (unnecessary) bigger
- sources should be available in SRC.RPM packages, not in RPM package themselves

If the decision is to ship these files in RPM as well (I think they should remain in Maven repo and SRC.RPM package only), we should do the same for all RPM packages.

Current (mixed) state is bad for a customer and looks as an issue from my PoV.

Comment 1 Fernando Nasser 2013-11-07 15:49:29 UTC

The -source artifacts are NOT the sources to build the software.  These are in the src.rpm.  These are different things, not duplications.

The sources artifacts are needed for one to get proper stack traces, they must reside besides the main artifact.

Ideally we should get sources at least for all public apis, which is what we are trying to do. It is difficult because some projects, specially third party ones, and in particular the ones that do not build with Maven, do not produce those.  But the situation is much improved now, which is wy you probably noticed it.

Comment 2 Pavel Janousek 2013-11-07 16:03:09 UTC

Well, in the case they are needed for proper stack trace generation (I didn't know that, sorry) where they are for ZIP based distro?

Comment 3 Fernando Nasser 2013-11-07 16:11:41 UTC

ZIPs are used in different environments and usually in association with Wolf.
In RPM istallations the "repo" is /usr/share/java

Comment 4 Pavel Janousek 2013-11-08 09:27:25 UTC

I'm a bit confused now. I understand, all RPM which didn't rebuild for EAP-6.2.0 are in some 'older' state.

But for ex. mod_cluster-0:1.2.6-1.Final_redhat_1.1 ('redhat_1.1' -> MEAD build) was rebuilt for EAP-6.2.0 again, but I'm missing all *-sources.jar (mod_cluster-container-spi-1.2.6.Final-redhat-1-sources.jar, mod_cluster-container-jbossweb-1.2.6.Final-redhat-1-sources.jar etc.).

All of these *-sources.jar are included in Maven repo ZIP for ER7.

Maybe I should rephrase my complain, but it doesn't look to be fully fixed.

Comment 5 Fernando Nasser 2013-11-08 13:57:29 UTC

That would be considered a bug in the mod_cluster wrapper.  Maybe it was left out because of the way mod_cluster runs.  I will ask it to be re-wrapped for the CR1, there is still time.

Please open individual BZs if you find things that missed the source artifacts like mod_cluster so we can farm them out to the builders.

P.S.: Please note that our effort to add missing source artifacts to builds was concentrated on things for which we ship javadocs (for 6.2.0).

Comment 6 Fernando Nasser 2013-11-08 16:05:34 UTC

Note: mod_cluster wrapper fixed.  Thanks for pointing that out.