Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser-0.9.0-1.fc21.src.rpm Description: A math parser Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6152402
Taking. I would appreciate it if you would review one of my review requests (e.g. bug 1031315 )
Well, before review this, I cannot find out any text files or so which suggests the license of this gem. Would you tell me how you knew this is under MIT?
Sure. I saw that there was an MIT-LICENSE file in upstream's Git repo. Also, I emailed both of the authors of the code to be doubly sure of the license. For completeness, I'm including copies of their emails in 0.9.0-2. * Mon Nov 18 2013 Ken Dreyer <ktdreyer> - 0.9.0-2 - Include email transcripts describing MIT license. Exact change in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-expression_parser.git/commit/?id=92161c45495293a0e4690f315768f1481cf964b6 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser-0.9.0-2.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6196395
Okay, now for -2: * License text - Please include the mail confirmation text to the binary rpms (note that the emails will be anyway visible into public when you include them into srpm and it is necessary) * rpmlint cleanup - Please cleanup the following rpmlint (just replace macro in comments with %%) ------------------------------------------------------- rubygem-expression_parser.src:53: W: macro-in-comment %{gem_instdir} rubygem-expression_parser.src:53: W: macro-in-comment %{gem_name} ------------------------------------------------------- Then I can approve this package.
(In reply to Mamoru TASAKA from comment #4) > * License text > - Please include the mail confirmation text to the binary rpms > (note that the emails will be anyway visible into public when > you include them into srpm and it is necessary) For this one, I think I'd rather include the MIT-LICENSE from Git upstream. What do you think?
(In reply to Ken Dreyer from comment #5) > (In reply to Mamoru TASAKA from comment #4) > > * License text > > - Please include the mail confirmation text to the binary rpms > > (note that the emails will be anyway visible into public when > > you include them into srpm and it is necessary) > > For this one, I think I'd rather include the MIT-LICENSE from Git upstream. > What do you think? I am okay with that.
Ok, thanks. * Tue Nov 19 2013 Ken Dreyer <ktdreyer> - 0.9.0-3 - Remove macro in comment - Remove email transcripts - Add MIT-LICENSE file from upstream Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-expression_parser.git/commit/?id=5561856da0d02fc2302fa43d6510ad975281bfae Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser-0.9.0-3.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6204514
One more issue: * install command ------------------------------------------- install -p %{SOURCE1} %{buildroot}%{gem_instdir}/MIT-LICENSE ------------------------------------------- - This causes the following rpmlint: ------------------------------------------- rubygem-expression_parser.noarch: E: script-without-shebang /usr/share/gems/gems/expression_parser-0.9.0/MIT-LICENSE ------------------------------------------- Please fix this when importing this package into git (by specifying mode like install -p -m 0644) ---------------------------------------------- This package (rubygem-expression_parser) is APPROVE by mtasaka ----------------------------------------------
Whoops, thanks for pointing out the missing permissions on install. I'll fix this before importing. Thanks mtasaka for the review! New Package SCM Request ======================= Package Name: rubygem-expression_parser Short Description: A math parser Owners: ktdreyer Branches: f19 f20
Git done (by process-git-requests).
rubygem-expression_parser-0.9.0-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-expression_parser-0.9.0-4.fc20
rubygem-expression_parser-0.9.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-expression_parser-0.9.0-4.fc19
rubygem-expression_parser-0.9.0-4.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-expression_parser-0.9.0-4.fc19 has been pushed to the Fedora 19 stable repository.
rubygem-expression_parser-0.9.0-4.fc20 has been pushed to the Fedora 20 stable repository.