spec https://github.com/repoforge/rpms/raw/master/specs/perl-DBD-ODBC/perl-DBD-ODBC.spec srpm https://github.com/holcapek/perl-DBD-ODBC/raw/master/perl-DBD-ODBC-1.45-1.fc19.src.rpm
Perhaps this will go smoother than https://bugzilla.redhat.com/show_bug.cgi?id=441830
SPEC URL is not the same one in SRPM. Dunno why you used a repoforge SPEC link. I've committed some small changes on your github link, please check. https://github.com/holcapek/perl-DBD-ODBC/pull/1
(In reply to Christopher Meng from comment #2) > SPEC URL is not the same one in SRPM. Dunno why you used a repoforge SPEC > link. My bad: https://github.com/holcapek/perl-DBD-ODBC/raw/master/perl-DBD-ODBC.spec > I've committed some small changes on your github link, please check. > > https://github.com/holcapek/perl-DBD-ODBC/pull/1 As far as I can tell, that looks good. I'm just wondering why did you remove all the perl module versions in (Build)Requires?
(In reply to Jan Holcapek from comment #3) > (In reply to Christopher Meng from comment #2) > > SPEC URL is not the same one in SRPM. Dunno why you used a repoforge SPEC > > link. > > My bad: > https://github.com/holcapek/perl-DBD-ODBC/raw/master/perl-DBD-ODBC.spec > > > I've committed some small changes on your github link, please check. > > > > https://github.com/holcapek/perl-DBD-ODBC/pull/1 > > As far as I can tell, that looks good. I'm just wondering why did you remove > all the perl module versions in (Build)Requires? Because the versions are too old, even RHEL5(the oldest product still in support period) has newer version of them.
Taking this for review. Dropping FE-NEEDSPONSOR, I'll sponsor Jan.
* Package named correctly * Latest stable version used * Package licensed correctly * License tag correct * SPEC file mostly clean and legible (see below) * Correct compiler flags used * Correct make flags used * Builds fine in mock (test dependencies missing, see below) * rpmlint happy * Filelist sane * Provides sane * Requires mostly sane (some extra, see below) 0.) Please split a long line: -%doc Changes FAQ if_you_are_taking_over_this_code.txt README README.adabas README.af README.hpux README.informix README.osx README.RH9 README.sqlserver README.unicode README.windows test_results.txt TO_DO +%doc Changes FAQ if_you_are_taking_over_this_code.txt +%doc README README.adabas README.af README.hpux README.informix ... Also, are _all_ these files needed? 1.) Please add required build dependencies: Test::Pod::Coverage Test::Pod 2.) These are not runtime dependencies Requires: perl(Test::Simple) >= 0.90 Requires: perl(Test::Version) >= 1.002001 3.) You may want to remove old RPM artifacts, at least for Rawhide BuildRoot, %clean section and %defattrs are no longer needed
(In reply to Lubomir Rintel from comment #6) > 0.) Please split a long line: > > -%doc Changes FAQ if_you_are_taking_over_this_code.txt README README.adabas > README.af README.hpux README.informix README.osx README.RH9 README.sqlserver > README.unicode README.windows test_results.txt TO_DO > +%doc Changes FAQ if_you_are_taking_over_this_code.txt > +%doc README README.adabas README.af README.hpux README.informix > ... > > Also, are _all_ these files needed? Well, they're not. Please have a look at the updated list. > 1.) Please add required build dependencies: > > Test::Pod::Coverage > Test::Pod Fixed. > 2.) These are not runtime dependencies > > Requires: perl(Test::Simple) >= 0.90 > Requires: perl(Test::Version) >= 1.002001 Fixed. > 3.) You may want to remove old RPM artifacts, at least for Rawhide > > BuildRoot, %clean section and %defattrs are no longer needed Fixed.
Thanks, seems all good to me now! By the way, it is customary to include links to an updated SPEC file and SRPM in response comments (and bump release) so that the reviewer can easily find the latest package and check what has changed. You can now proceed requesting the repository [1] [1] http://fedoraproject.org/wiki/Package_SCM_admin_requests The package is APPROVED
New Package SCM Request ======================= Package Name: perl-DBD-ODBC Short Description: ODBC Driver for DBI Owners: holcapek Branches: f18 f19 f20 el6 InitialCC: lkundrak perl-sig
Git done (by process-git-requests).
perl-DBD-ODBC-1.45-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-DBD-ODBC-1.45-1.el6
perl-DBD-ODBC-1.45-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-DBD-ODBC-1.45-1.fc19
perl-DBD-ODBC-1.45-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-DBD-ODBC-1.45-1.fc18
perl-DBD-ODBC-1.45-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-DBD-ODBC-1.45-1.fc20
perl-DBD-ODBC-1.45-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
perl-DBD-ODBC-1.45-1.fc18 has been pushed to the Fedora 18 stable repository.
perl-DBD-ODBC-1.45-1.fc19 has been pushed to the Fedora 19 stable repository.
perl-DBD-ODBC-1.45-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
perl-DBD-ODBC-1.45-1.fc20 has been pushed to the Fedora 20 stable repository.