Red Hat Bugzilla – Bug 1028663
AFR: self-heal daemon crawler not obeying the 'cluster.heal-timeout' time interval
Last modified: 2014-07-11 15:17:40 EDT
+++ This bug was initially created as a clone of Bug #1027559 +++
Description of problem:
The afr_start_crawl() function is called before expiry of "cluster.heal-timeout" seconds (which is 600 seconds by default)
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.Create and start a 1x2 replica volume using 2 different nodes.
2.gluster v set <VOLNAME> diagnostics.client-log-level DEBUG
3.gluster v set <VOLNAME> cluster.heal-timeout 300
4.tailf /var/log/glusterfs/glustershd.log (on either of the nodes)
[2013-11-07 10:32:06.058154] D [afr-self-heald.c:1233:afr_start_crawl] 0-testvol-replicate-0: starting crawl 1 for testvol-client-0
[2013-11-07 10:32:07.059428] D [afr-self-heald.c:1233:afr_start_crawl] 0-testvol-replicate-0: starting crawl 1 for testvol-client-0
The time interval between 2 successive invocations of afr_start_crawl() is just one second.
The crawler must start only once in "cluster.heal-timeout" seconds.
--- Additional comment from RHEL Product and Program Management on 2013-11-07 00:24:39 EST ---
Since this issue was entered in bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.
REVIEW: http://review.gluster.org/6243 (libglusterfs: fix bug in timespec adjustment) posted (#2) for review on master by Ravishankar N (email@example.com)
COMMIT: http://review.gluster.org/6243 committed in master by Anand Avati (firstname.lastname@example.org)
Author: Ravishankar N <email@example.com>
Date: Sat Nov 9 11:56:34 2013 +0000
libglusterfs: fix bug in timespec adjustment
The argument to the timespec_adjust_delta() function introudced in
commit 6836118b21 needs to be passed by reference rather than by value
for the function to do it's job.
Signed-off-by: Ravishankar N <firstname.lastname@example.org>
Tested-by: Gluster Build System <email@example.com>
Reviewed-by: Anand Avati <firstname.lastname@example.org>