RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1029458 - xfs_check deprecation
Summary: xfs_check deprecation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: xfsprogs
Version: 7.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Boris Ranto
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-12 12:34 UTC by Karel Volný
Modified: 2014-06-18 04:55 UTC (History)
2 users (show)

Fixed In Version: xfsprogs-3.2.0-0.7.alpha1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 12:04:11 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Karel Volný 2013-11-12 12:34:12 UTC 
Description of problem:
xfs_check is about to be deprecated and should be (fully?) replaced by xfs_repair

IMHO we should remove xfs_check from RHEL7 before the release - once it gets in, we will have to support it for the lifecycle of RHEL7 which should span long after the upstream drops support

Version-Release number of selected component (if applicable):
xfsprogs-3.2.0-0.1.alpha1.el7

How reproducible:
always

Steps to Reproduce:
0. yum install -y xfsprogs
1. xfs_check

Actual results:
xfs_check is deprecated and scheduled for removal in June 2014.
Please use xfs_repair -n <dev> instead.
Usage: xfs_check [-fsvV] [-l logdev] [-i ino]... [.b bno].. special

Expected results:
bash: xfs_check: No such file or directory

Additional info:
Comment 2 Eric Sandeen 2013-11-12 17:21:07 UTC 
Agreed, I'm happy to remove it now.

Thanks,
-Eric
Comment 4 Boris Ranto 2014-01-03 11:00:39 UTC 
Hi Eric,

the man page for xfs_check is still a part of the xfsprogs package:

[root@lenovo-rd230-01 ~]# rpm -ql xfsprogs |grep xfs_check
/usr/share/man/man8/xfs_check.8.gz

Is this intentional or just an overlook?
Comment 5 Eric Sandeen 2014-01-03 18:13:19 UTC 
It's an oversight.  :(

+# xfs_check is deprecated; nuke it from orbit for RHEL7
+rm -f $RPM_BUILD_ROOT/%{_sbindir}/xfs_check
+rm -f $RPM_BUILD_ROOT/%{_mandir}/man8/xfs_check.8.gz

Maybe the *.gz doesn't exist here yet, at the point that it was rm -f'd.  (I probably should have left out the "-f").
Comment 6 Eric Sandeen 2014-01-03 18:38:38 UTC 
Strange, when I rebuild the RPM, the manpage is not present:

# rpm -qpl /root/rpmbuild/RPMS/x86_64/xfsprogs-3.2.0-0.4.alpha2.el6.x86_64.rpm | grep check
/usr/sbin/xfs_ncheck
/usr/share/man/man8/xfs_ncheck.8.gz
#
Comment 8 Boris Ranto 2014-02-25 15:02:44 UTC 
This probably should not be in ON_QA, The man page is still there in the most recent xfsprogs package (3.2.0-0.6.alpha2.el7) although the manual rebuild produced xfs_check-man-page-free build.

I though the reason might be that the make command in spec file does not override the PKG_MAN_DIR variable but the koji scratch build with PKG_MAN_DIR=%{_mandir} still produced an xfsprogs package with xfs_check man page.

Looking at the build log, the command for removal is there and the path for removal seems to be correct. The only thing that comes in mind is that the command is run after the files are packaged but it does not make sense since the xfs_check binary is removed just before the man page and it is not a part of the resulting xfsprogs rpm. Maybe, this is a koji bug? If that is the case, then we could probably move this bz to verified.
Comment 9 Eric Sandeen 2014-02-25 16:17:15 UTC 
Ok, let's move this back to assigned and I'll fix it up.  I'll remove <path>/man8/xfs_check* - that seems to work.

-Eric
Comment 10 Eric Sandeen 2014-02-25 17:01:42 UTC 
Ok, I need blocker to be abel to fix this, I guess.
Comment 11 Boris Ranto 2014-03-04 10:09:21 UTC 
Verified in xfsprogs-3.2.0-0.8.alpha2.el7. Both xfs_check binary as well as man page are no longer present in the xfsprogs package.
Comment 12 Ludek Smid 2014-06-13 12:04:11 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.