Bug 1029575 - Dist-geo-rep: use-tarssh option takes even garbage value and returns success
Summary: Dist-geo-rep: use-tarssh option takes even garbage value and returns success
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: geo-replication
Version: 2.1
Hardware: x86_64
OS: Linux
high
medium
Target Milestone: ---
: ---
Assignee: Avra Sengupta
QA Contact: M S Vishwanath Bhat
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-12 16:17 UTC by M S Vishwanath Bhat
Modified: 2016-06-01 01:56 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.4.0.44rhs-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-27 15:47:36 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:1769 0 normal SHIPPED_LIVE Red Hat Storage 2.1 enhancement and bug fix update #1 2013-11-27 20:17:39 UTC

Description M S Vishwanath Bhat 2013-11-12 16:17:26 UTC
Description of problem:
geo-rep config CLI takes even the garbage value and succeeds.



Version-Release number of selected component (if applicable):
glusterfs-3.4.0.43rhs-1.el6rhs.x86_64


How reproducible:
Always

Steps to Reproduce:
1. gluster v geo master slave_url config use-tarssh blah

Actual results:

[root@harrier ~]# gluster v geo master falcon::slave config use-tarssh true
geo-replication config updated successfully
[root@harrier ~]# gluster v geo master falcon::slave config | grep tar
use_tarssh: true
ssh_command_tar: ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i /var/lib/glusterd/geo-replication/tar_ssh.pem
[root@harrier ~]# gluster v geo master falcon::slave config use-tarssh blah
geo-replication config updated successfully
[root@harrier ~]# gluster v geo master falcon::slave config | grep tar
use_tarssh: blah
ssh_command_tar: ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i /var/lib/glusterd/geo-replication/tar_ssh.pem
[root@harrier ~]# gluster v geo master falcon::slave config use-tarssh dontusetarssh
geo-replication config updated successfully
[root@harrier ~]# gluster v geo master falcon::slave config | grep tar
use_tarssh: dontusetarssh
ssh_command_tar: ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i /var/lib/glusterd/geo-replication/tar_ssh.pem



Expected results:
use-tarssh should take only true, on or some other valid and allowed values.


Additional info:

Comment 2 Avra Sengupta 2013-11-13 09:32:21 UTC
Fixed with https://code.engineering.redhat.com/gerrit/15619

Comment 3 M S Vishwanath Bhat 2013-11-13 16:03:04 UTC
With Invalid values


[root@pythagoras ]# gluster v geo master euclid::slave config use-tarssh blah
Invalid value(blah) for option use-tarssh
geo-replication command failed
[root@pythagoras ]# gluster v geo master euclid::slave config use-tarssh gibber
Invalid value(gibber) for option use-tarssh
geo-replication command failed


Now the valid values


[root@pythagoras ]# gluster v geo master euclid::slave config use-tarssh true
geo-replication config updated successfully
[root@pythagoras ]# gluster v geo master euclid::slave config | grep tar
use_tarssh: true
ssh_command_tar: ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i /var/lib/glusterd/geo-replication/tar_ssh.pem
[root@pythagoras ]# gluster v geo master euclid::slave config use-tarssh false
geo-replication config updated successfully
[root@pythagoras ]# gluster v geo master euclid::slave config | grep tar
use_tarssh: false
ssh_command_tar: ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i /var/lib/glusterd/geo-replication/tar_ssh.pem
[root@pythagoras ]# gluster v geo master euclid::slave config use-tarssh 1
geo-replication config updated successfully
[root@pythagoras ]# gluster v geo master euclid::slave config | grep tar
use_tarssh: 1
ssh_command_tar: ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i /var/lib/glusterd/geo-replication/tar_ssh.pem
[root@pythagoras ]# gluster v geo master euclid::slave config use-tarssh 0
geo-replication config updated successfully
[root@pythagoras ]# gluster v geo master euclid::slave config | grep tar
use_tarssh: 0
ssh_command_tar: ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i /var/lib/glusterd/geo-replication/tar_ssh.pem



Not it takes only true, false, yes, no, 1 and 0 as valid values. So moving the bug to verified.

Comment 4 errata-xmlrpc 2013-11-27 15:47:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1769.html


Note You need to log in before you can comment on or make changes to this bug.