Red Hat Bugzilla – Bug 1029925
upgrading a server but installing new agent puts agent in wrong place
Last modified: 2014-01-02 15:43:12 EST
I'm writing this up in a BZ because I am not sure what the correct thing to do is. I think this might be wrong.
1. Install an older version but only install the server (say JON 3.1.2 Server)
2. Unzip a new version (say JON 3.2.ER5)
3. Upgrade the old version via rhqctl upgrade --from-server-dir=<3.1.2 location>
4. Notice where the agent is installed.
If the 3.1.2 was installed here:
and the new 3.2 was installed here:
the new agent ended up getting installed here:
Now, notice it got installed in the parent directory of the old server (the old server was in 3.1.2/jon-server-3.1.2, the parent is thus 3.1.2 and therefore the agent went under there).
This doesn't seem right. Should the new agent go under /opt/jon (i.e. /opt/jon/rhq-agent) since the new server's install dir is /opt/jon/3.2 and thus its parent dir is /opt/jon?
Note that the storage node was installed in /opt/jon/rhq-data
Yeah, this seems wrong to me. I would expect the agent to end up in:
In Upgrade.java, line 623, there is this:
Notice it is installing the agent in the old agent location (where we looked for the old agent to be installed).
But if the agent isn't installed there (that is, the old server being upgraded didn't also have an agent installed), then we want to install a new agent in the new expected location. So I think this line needs to change to:
master commit: 9e88f665a6306096e4eb556dc0521e11093d0742
release/jon3.2.x commit: d227e1504c6f5ea40b395c76df1fc11bee3d2af0
Moving to ON_QA as available for testing with new brew build.
Mass moving all of these from ER6 to target milestone ER07 since the ER6 build was bad and QE was halted for the same reason.