Pull request integrated, setting to on QA for the first CR release after BETA (i.e. after 3.2)

Tests are still not passing :( 
The same problem.

But now, with one line lower (of course, import org.infinispan.util.ByteArrayKey; was added):

Caused by: java.lang.ClassNotFoundException: org.infinispan.util.ByteArrayKey from [Module "org.infinispan:main" from local module loader @284bd160 (finder: local module finder @99f0a4b (roots: /home/tsykora/programs/eclipseWorkspace/Infinispan-server-tsykora/infinispan-server/testsuite/target/server/node1/modules,/home/tsykora/programs/eclipseWorkspace/Infinispan-server-tsykora/infinispan-server/testsuite/target/server/node1/modules/system/layers/base))]
	at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:190)
	at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:468)
	at org.jboss.modules.ConcurrentClassLoader.performLoadClassChecked(ConcurrentClassLoader.java:456)
	at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:398)
	at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:120)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at org.jboss.marshalling.AbstractClassResolver.loadClass(AbstractClassResolver.java:135)
	at org.jboss.marshalling.AbstractClassResolver.resolveClass(AbstractClassResolver.java:116)
	at org.jboss.marshalling.river.RiverUnmarshaller.doReadClassDescriptor(RiverUnmarshaller.java:947)
	at org.jboss.marshalling.river.RiverUnmarshaller.doReadNewObject(RiverUnmarshaller.java:1259)
	at org.jboss.marshalling.river.RiverUnmarshaller.doReadObject(RiverUnmarshaller.java:276)
	at org.jboss.marshalling.river.RiverUnmarshaller.doReadObject(RiverUnmarshaller.java:213)
	at org.jboss.marshalling.river.RiverUnmarshaller.doReadCollectionObject(RiverUnmarshaller.java:184)
	at org.jboss.marshalling.river.RiverUnmarshaller.readCollectionData(RiverUnmarshaller.java:777)
	at org.jboss.marshalling.river.RiverUnmarshaller.doReadObject(RiverUnmarshaller.java:656)
	at org.jboss.marshalling.river.RiverUnmarshaller.doReadObject(RiverUnmarshaller.java:213)
	at org.jboss.marshalling.AbstractObjectInput.readObject(AbstractObjectInput.java:37)
	at org.infinispan.commons.marshall.jboss.AbstractJBossMarshaller.objectFromObjectStream(AbstractJBossMarshaller.java:140)
	at org.infinispan.commons.marshall.jboss.AbstractJBossMarshaller.objectFromByteBuffer(AbstractJBossMarshaller.java:118)
	at org.infinispan.commons.marshall.AbstractMarshaller.objectFromByteBuffer(AbstractMarshaller.java:82)
	at org.infinispan.persistence.remote.upgrade.HotRodTargetMigrator.synchronizeData(HotRodTargetMigrator.java:62)
	... 15 more

Martin Gencur <mgencur> updated the status of jira ISPN-3712 to Reopened

Martin Gencur <mgencur> made a comment on jira ISPN-3712

Tests are still failing. This is not working yet.

Vojtech Juranek <vjuranek> made a comment on jira ISPN-3712

HI,
I spot same/similar issue in ispn testsuite (org.infinispan.cli.interpreter.UpgradeTest.testSynchronization):
{noformat}
Caused by: java.lang.ClassNotFoundException: org.infinispan.util.ByteArrayKey
	at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
	... 26 more
{noformat}
Whole exception can be found here:
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JDG/view/FUNC/job/edg-60-ispn-testsuite-solaris/125/USE_JDK=JDK6,jdk=java17_default,label=sol11_x86_64/testReport/junit/org.infinispan.cli.interpreter/UpgradeTest/testSynchronization/

Vojtech Juranek <vjuranek> made a comment on jira ISPN-3712

PRs [1,2] seems to fix the issue

[1] https://github.com/infinispan/infinispan-server/pull/202
[2] https://github.com/infinispan/infinispan/pull/2260

Yes, confirming this investigation.
Tests are passing with latest community ispn-server version. Brilliant, Tristan!

Expecting this BZ to be set ON_QA for ER6 for final verification.

Tristan, your words :)

edit modules/system/layers/base/org/infinispan/commons/main/module.xml

add this line <module name="org.infinispan.adaptor52x" optional="true" export="true"/>

This made HR roll ups from 6.1.GA to ER6 working.

Expecting this fix in ER7. 

Setting back to ASSIGNED.

It is working, but server needs to be "down-patched" to use Hot Rod client protocol 1.2. With these settings it was verified.

Thank you!