Bug 1030580 - Feature request (CLI): Add an option to the CLI to fetch just incremental or cumulative I/O statistics
Summary: Feature request (CLI): Add an option to the CLI to fetch just incremental or ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaushal
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-14 17:41 UTC by Dawit Alemu
Modified: 2016-05-06 01:55 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-11 08:24:38 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Dawit Alemu 2013-11-14 17:41:39 UTC
Description of problem:
Currently 'volume profile info' fetches both cumulative and incremental I/O statistics. Add an option, to the CLI, to fetch just incremental or cumulative statistics.

Version-Release number of selected component (if applicable):


How reproducible:
Feature does not exist.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2013-12-02 18:37:16 UTC
REVIEW: http://review.gluster.org/6264 (cli: Add an option to fetch just incremental or cumulative I/0 information) posted (#4) for review on master by Dawit Alemu (dalemu)

Comment 2 Anand Avati 2013-12-04 02:09:42 UTC
COMMIT: http://review.gluster.org/6264 committed in master by Anand Avati (avati) 
------
commit 133c370ec5e2688b6734acb087fe3769cb900a74
Author: Dawit Alemu <dalemu>
Date:   Thu Nov 14 12:52:14 2013 -0500

    cli: Add an option to fetch just incremental or cumulative I/0
    information
    
    'volume profile info' fetches both cumulative and incremental
    I/O statistics. There isn't a way to fetch just cumulative or
    incremental statistics.
    
    This change introduces two optional arguments, namely "incremental"
    and "cumulative", that can be tacked on to 'volume profile info'.
    In other words, the new command format is
    
    volume profile <VOLNAME> {start | info [incremental | cumulative]
    | stop} [nfs]
    
    'volume profile info incremental' - fetches incremental stats
    'volume profile info cumulative' - fetches cumulative stats
    'volume profile info' - fetches incremental and cumulative stats
    
    Change-Id: I5ddb45d990542ea611d23d251efebfec46f472d0
    BUG: 1030580
    Signed-off-by: Dawit Alemu <dalemu>
    Reviewed-on: http://review.gluster.org/6264
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>

Comment 3 Anand Avati 2014-03-11 12:39:00 UTC
REVIEW: http://review.gluster.org/7217 (debug/io-stats:fix compile warning) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 4 Anand Avati 2014-03-22 12:27:32 UTC
COMMIT: http://review.gluster.org/7217 committed in master by Vijay Bellur (vbellur) 
------
commit 16151032862af8ee70f14eff57162d829d8d75f9
Author: Ravishankar N <ravishankar>
Date:   Mon Mar 10 18:28:02 2014 +0530

    debug/io-stats:fix compile warning
    
    Compiler Warning:
    ---------------------------------------------------------
    io-stats.c: In function 'io_stats_dump':
    io-stats.c:950:24: warning: comparison between 'gf1_cli_stats_op' and
    'enum gf1_cli_info_op' [-Wenum-compare]
                     if (op == GF_CLI_INFO_ALL ||
    io-stats.c:951:24: warning: comparison between 'gf1_cli_stats_op' and
    'enum gf1_cli_info_op' [-Wenum-compare]
                         op == GF_CLI_INFO_CUMULATIVE)
                            ^
    ---------------------------------------------------------
    Fix: Use the appropriate enum in function defintion of io_stats_dump().
    Note: Using the same BZ ID as the commit that introduced this argument.
    
    Change-Id: I24e1aaf9ab86b4f337e3daa729d561ec208f2a95
    BUG: 1030580
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/7217
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Niels de Vos 2014-09-22 12:32:45 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 6 Niels de Vos 2014-11-11 08:24:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.