Description of problem: The above error message is displayed after configuring a bridge interface with NetworkManager Version-Release number of selected component (if applicable): libvirt-1.0.5.6-3.fc19.x86_64 netcf-libs-0.2.3-4.fc19.x86_64 NetworkManager-0.9.8.8-1.fc19.x86_64 How reproducible: always Steps to Reproduce: 1. create bridge configuration with NetworkManager 2. run virt-manager and open "Network Interfaces" tab in localhost connection details, or run virt-install Actual results: "XML error: bridge stp shold be on or off got yes" Expected results: No error message Additional info: NM puts "yes" or "no" in the ifcfg file depending on the user STP setting: # grep STP /etc/sysconfig/network-scripts/ifcfg-br0 STP=no the brctl tool accepts both "on"/"off" and "yes"/"no". But libvirt handles only "on" and "off".
Created attachment 824571 [details] proposed patch
Confirmed - the patch from comment #1 solves this problem.
Can you please post this patch upstream to libvir-list? It will get reviewed faster, and it is easier for upstream to apply patches that go through the list than patches that require firing up a web browser.
I sent the mail in the hope the list does't require subscription.
(In reply to Martin Wilck from comment #4) > I sent the mail in the hope the list does't require subscription. Thanks; it came through just fine: https://www.redhat.com/archives/libvir-list/2013-November/msg00581.html List policy is to reply-all, so that you need not subscribe. Hopefully you get a response soon.
As Dan mentioned in reply to that message, at its root this sounds like a netcf issue, reassigning.
Comment from Mailing list: "The XML schema does not care what values the brctl tool exposes. It standardizes on on & off for values. Whatever tool is creating this XML (netcf I guess) should translate from the values brctl uses to what the XML requires."
Created attachment 825430 [details] [PATCH] redhat-put.xsl: transform STP value to "on/off" Another proposed patch, for netcf this time. (wrt Daniel's comment, I haven't seen a schema file that would specify the netcf output in that detail. However I really don't care if the fix is applied in netcf or libvirt. I want this to get fixed either way).
> (wrt Daniel's comment, I haven't seen a schema file that would specify the > netcf output in that detail. Found it now. It's in interface.rng: <attribute name="stp"> <ref name="on-or-off"/> </attribute>
(In reply to Martin Wilck from comment #8) > Created attachment 825430 [details] > [PATCH] redhat-put.xsl: transform STP value to "on/off" > > Another proposed patch, for netcf this time. Thanks for taking the time to make these patches. Sorry to keep doing this to you, but if you could send this netcf patch to netcf-devel.org I can more easily push it into git with proper attribution to you. (you should be able to post without subscribing - it will just queue up the mail to wait for an admin (me) to clear it.
Sent the email. Subject: [PATCH] redhat-put.xsl: transform STP value to "on/off"
Hmm, I got this: You are not allowed to post to this mailing list, and your message has been automatically rejected. If you think that your messages are being rejected in error, contact the mailing list owner at netcf-devel-owner.org.
(In reply to Martin Wilck from comment #12) > You are not allowed to post to this mailing list, and your message has > been automatically rejected. Oops. I had thought the netcf mailing list was configured similarly to libvir-list. I just changed it to hold-for-moderation messages from non-subscribers rahter than deleting them. Can you make one more try to that address? If that doesn't work, just email the patch to my email directly, and I'll forward it on to the list. (BTW, I'm assuming that you're making the patch with git send-email.)
This has been fixed upstream. Do you need a fix in F19? F20? commit 048d13afcc91f4a16a80012aa34b9a024d95368e Author: Martin Wilck <martin.wilck.com> Date: Mon Nov 18 12:35:15 2013 +0100 transform STP value from "yes/no" to "on/off" in redhat-put.xsl Some tools (e.g. NetworkManager) use "yes"/"no" in config files rather than "on/off". netcf needs to transform this in order to conform with the schema.
I'm still using F19, but I could live with the fix being in F20 is the first place. RHEL7 might also be considered I guess.
netcf-0.2.3-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/netcf-0.2.3-5.fc19
Package netcf-0.2.3-5.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing netcf-0.2.3-5.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-6011/netcf-0.2.3-5.fc19 then log in and leave karma (feedback).
netcf-0.2.3-5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.