Bug 1031400 - Review Request: php-symfony-icu - Symfony Icu Component
Summary: Review Request: php-symfony-icu - Symfony Icu Component
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1021749
TreeView+ depends on / blocked
Reported: 2013-11-17 16:33 UTC by Shawn Iwinski
Modified: 2013-12-15 20:23 UTC (History)
2 users (show)

Fixed In Version: php-symfony-icu-1.1.0-3.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-12-09 02:00:46 UTC
Type: ---
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
phpci.log (8.52 KB, text/plain)
2013-11-18 06:44 UTC, Remi Collet
no flags Details
review.txt (8.12 KB, text/plain)
2013-11-18 06:45 UTC, Remi Collet
no flags Details

Description Shawn Iwinski 2013-11-17 16:33:29 UTC
Spec URL: https://raw.github.com/siwinski/rpms/fed1d3b46a98f0ded174dcd9899a2a85a0667a90/php-symfony2-icu.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-symfony2-icu-1.1.0-1.fc19.src.rpm

Description: Contains data of the ICU library.

Fedora Account System Username: siwinski

NOTE: Version 1.1.0 is required for el6 and I will update this pkg to the latest version after initial import

Comment 2 Remi Collet 2013-11-18 06:44:19 UTC
Created attachment 825411 [details]

phpcompatinfo version 2.25.0.

Comment 3 Remi Collet 2013-11-18 06:45:04 UTC
Created attachment 825412 [details]

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1031400
Buildroot used: fedora-19-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

Comment 4 Remi Collet 2013-11-18 06:46:38 UTC
[!] Package installs properly.
	Wait for dependency before import
[~]: Package is named according to the Package Naming Guidelines.
	could be php-symfony-icu, but 2 is acceptable.
[~]: Latest version is packaged.
	1.1 for EPEL-6, 1.2 for Fedora => ok.
[~]: %check is present and all tests pass.
	intl not yet available
	I would have prefer to have test disabled, but... ok
[!]: All build dependencies are listed in BuildRequires...
	=> BuildRequires: libicu >= %{libicu_min_ver}
	so you can drop the pkgconfig stuff.
[!]: Requires correct, justified where necessary.
	=> Requires: libicu >= %{libicu_min_ver}
	libicu is already pulled by php-intl, so this is only for version check

So only need to fix the libicu requirement (simpler), and wait for php-symfony2-intl approval before import.

Comment 5 Remi Collet 2013-11-18 12:12:08 UTC
I think you have to drop the "Requires; php-symfony2-intl".
As this package is BuildRequired by main symfony package.

As this package is not designed to be usable directly , but only used through sympfony2/Intl, I don't think that installing it without Intl will be an issue.

Comment 6 Shawn Iwinski 2013-11-22 19:31:50 UTC
- Renamed from "php-symfony2-icu" to "php-symfony-icu"
- Direct libicu dependency instead of using pkgconfig
- Added tests (only run with rpmbuild --with tests)

Spec URL: https://raw.github.com/siwinski/rpms/7191607846aacf346cb1b956607a50afba5560fa/php-symfony-icu.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-symfony-icu-1.1.0-2.fc19.src.rpm

Comment 7 Remi Collet 2013-11-23 12:17:44 UTC
All blocker are fixed.

Upgrade path from php-channel-symfony2 (all packages) to php-symfony-* => OK.

===== APPROVED =====

Comment 8 Shawn Iwinski 2013-11-23 21:41:36 UTC
THANKS for the review and all of the help!

New Package SCM Request
Package Name: php-symfony-icu
Short Description: Symfony Icu Component
Owners: siwinski remi
Branches: f19 f20 el6

Comment 9 Gwyn Ciesla 2013-11-25 13:24:00 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2013-11-28 04:56:45 UTC
php-symfony-icu-1.1.0-3.el6 has been submitted as an update for Fedora EPEL 6.

Comment 11 Fedora Update System 2013-11-28 04:56:57 UTC
php-symfony-icu-1.2.0-1.fc20 has been submitted as an update for Fedora 20.

Comment 12 Fedora Update System 2013-11-28 04:57:06 UTC
php-symfony-icu-1.2.0-1.fc19 has been submitted as an update for Fedora 19.

Comment 13 Fedora Update System 2013-11-29 16:00:56 UTC
php-symfony-icu-1.2.0-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 14 Fedora Update System 2013-12-09 02:00:46 UTC
php-symfony-icu-1.2.0-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 15 Fedora Update System 2013-12-14 02:55:24 UTC
php-symfony-icu-1.2.0-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 16 Fedora Update System 2013-12-15 20:23:46 UTC
php-symfony-icu-1.1.0-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.