Spec URL: https://raw.github.com/siwinski/rpms/fed1d3b46a98f0ded174dcd9899a2a85a0667a90/php-symfony2-icu.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-symfony2-icu-1.1.0-1.fc19.src.rpm Description: Contains data of the ICU library. Fedora Account System Username: siwinski NOTE: Version 1.1.0 is required for el6 and I will update this pkg to the latest version after initial import
Ooops, wrong spec URL... Spec URL: https://raw.github.com/siwinski/rpms/539215a11b94d9dbcbf8e15e281c8c6e8a3b215f/php-symfony2-icu.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-symfony2-icu-1.1.0-1.fc19.src.rpm
Created attachment 825411 [details] phpci.log phpcompatinfo version 2.25.0.
Created attachment 825412 [details] review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1031400 Buildroot used: fedora-19-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG
[!] Package installs properly. Wait for dependency before import [~]: Package is named according to the Package Naming Guidelines. could be php-symfony-icu, but 2 is acceptable. [~]: Latest version is packaged. 1.1 for EPEL-6, 1.2 for Fedora => ok. [~]: %check is present and all tests pass. intl not yet available I would have prefer to have test disabled, but... ok [!]: All build dependencies are listed in BuildRequires... => BuildRequires: libicu >= %{libicu_min_ver} so you can drop the pkgconfig stuff. [!]: Requires correct, justified where necessary. => Requires: libicu >= %{libicu_min_ver} libicu is already pulled by php-intl, so this is only for version check So only need to fix the libicu requirement (simpler), and wait for php-symfony2-intl approval before import.
I think you have to drop the "Requires; php-symfony2-intl". As this package is BuildRequired by main symfony package. As this package is not designed to be usable directly , but only used through sympfony2/Intl, I don't think that installing it without Intl will be an issue.
- Renamed from "php-symfony2-icu" to "php-symfony-icu" - Direct libicu dependency instead of using pkgconfig - Added tests (only run with rpmbuild --with tests) Spec URL: https://raw.github.com/siwinski/rpms/7191607846aacf346cb1b956607a50afba5560fa/php-symfony-icu.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-symfony-icu-1.1.0-2.fc19.src.rpm
All blocker are fixed. Upgrade path from php-channel-symfony2 (all packages) to php-symfony-* => OK. ===== APPROVED =====
THANKS for the review and all of the help! New Package SCM Request ======================= Package Name: php-symfony-icu Short Description: Symfony Icu Component Owners: siwinski remi Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
php-symfony-icu-1.1.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-symfony-icu-1.1.0-3.el6
php-symfony-icu-1.2.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-symfony-icu-1.2.0-1.fc20
php-symfony-icu-1.2.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-symfony-icu-1.2.0-1.fc19
php-symfony-icu-1.2.0-1.fc20 has been pushed to the Fedora 20 testing repository.
php-symfony-icu-1.2.0-1.fc19 has been pushed to the Fedora 19 stable repository.
php-symfony-icu-1.2.0-1.fc20 has been pushed to the Fedora 20 stable repository.
php-symfony-icu-1.1.0-3.el6 has been pushed to the Fedora EPEL 6 stable repository.