Bug 1031423 - No system /etc/xattr.conf provided to exclude copying certain extended attributes
Summary: No system /etc/xattr.conf provided to exclude copying certain extended attrib...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: attr
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-17 18:49 UTC by Pádraig Brady
Modified: 2019-06-10 13:37 UTC (History)
2 users (show)

Fixed In Version: attr-2.4.48-6.fc31
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-10 13:37:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
sample xattr.conf from http://marc.info/?l=linux-xfs&m=119359384800408 (853 bytes, text/plain)
2013-11-17 18:49 UTC, Pádraig Brady
no flags Details

Description Pádraig Brady 2013-11-17 18:49:04 UTC
Created attachment 825281 [details]
sample xattr.conf from http://marc.info/?l=linux-xfs&m=119359384800408

I noticed that cp and mv with --preserve=xattr will copy system.posix_acl_access extended attributes, which can have side effects with permissions.
This is a little surprising and divergent from other systems that provide the attaced /etc/xattr.conf

There is also security.selinux extended attributes to consider here.
It might be argued that they might be excluded from such copies also,
given that they're otherwise handled by cp and mv at least.

Comment 1 Kamil Dudka 2013-11-18 17:20:45 UTC
I have asked upstream to include the file into their distribution of attr:

http://lists.nongnu.org/archive/html/acl-devel/2013-11/msg00007.html

Comment 2 Kamil Dudka 2013-11-19 13:44:26 UTC
upstream commit:

http://git.savannah.gnu.org/cgit/attr.git/commit/?id=fe92f96a

Comment 3 Kamil Dudka 2013-11-19 15:04:30 UTC
fixed in attr-2.4.47-4.fc21

Comment 4 Kamil Dudka 2018-11-06 14:02:17 UTC
I think that nfs4_acl attributes should be preserved with --preserve=xattr because there is no other way to have them preserved by cp(1):

--- a/xattr.conf
+++ b/xattr.conf
@@ -7,8 +7,6 @@
 #   permissions - copy when trying to preserve permissions.
 #   skip - do not copy.

-system.nfs4_acl                        permissions
-system.nfs4acl                 permissions
 system.posix_acl_access                permissions
 system.posix_acl_default       permissions
 trusted.SGI_ACL_DEFAULT                skip            # xfs specific

Comment 5 Kamil Dudka 2018-12-14 08:37:49 UTC
patch proposed to GNU coreutils upstream:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33644

Comment 6 Ben Cotton 2019-02-19 17:11:33 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 30 development cycle.
Changing version to '30.

Comment 8 Kamil Dudka 2019-06-10 13:37:03 UTC
(In reply to Kamil Dudka from comment #7)
> patches proposed to libattr upstream:
> 
> http://lists.nongnu.org/archive/html/acl-devel/2019-03/msg00000.html
> http://lists.nongnu.org/archive/html/acl-devel/2019-03/msg00001.html

There has been no feedback from upstream in the last 3 months.  I have pushed the patches to Fedora rawhide:

https://src.fedoraproject.org/rpms/attr/c/63e7de99


Note You need to log in before you can comment on or make changes to this bug.